| Message ID | 1507518307-4823-1-git-send-email-baijiaju1990@163.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
diff --git a/fs/cachefiles/namei.c b/fs/cachefiles/namei.c index 3978b32..39e1504 100644 --- a/fs/cachefiles/namei.c +++ b/fs/cachefiles/namei.c @@ -83,7 +83,7 @@ static noinline void cachefiles_printk_object(struct cachefiles_object *object, { u8 *keybuf; - keybuf = kmalloc(CACHEFILES_KEYBUF_SIZE, GFP_NOIO); + keybuf = kmalloc(CACHEFILES_KEYBUF_SIZE, GFP_ATOMIC); if (object) __cachefiles_printk_object(object, "", keybuf); if (xobject)
The kernel may sleep under a write spinlock, and the function call path is: cachefiles_mark_object_active (acquire the spinlock) cachefiles_printk_object kmalloc(GFP_NOIO) --> may sleep To fix it, GFP_NOIO is replaced with GFP_ATOMIC. This bug is found by my static analysis tool and my code review. Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com> --- fs/cachefiles/namei.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)