From patchwork Wed Jan 3 15:11:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amir Goldstein X-Patchwork-Id: 10142479 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0A3D2601A1 for ; Wed, 3 Jan 2018 15:11:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EF570291C4 for ; Wed, 3 Jan 2018 15:11:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E6492292C6; Wed, 3 Jan 2018 15:11:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6ADF2292BC for ; Wed, 3 Jan 2018 15:11:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753335AbeACPLB (ORCPT ); Wed, 3 Jan 2018 10:11:01 -0500 Received: from mail-wr0-f196.google.com ([209.85.128.196]:39257 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753331AbeACPK5 (ORCPT ); Wed, 3 Jan 2018 10:10:57 -0500 Received: by mail-wr0-f196.google.com with SMTP id o101so1877502wrb.6; Wed, 03 Jan 2018 07:10:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=5F/oxoaNwFenWfg08tNUegoOEfFql+LkieCTkIBTIfs=; b=Jw8SnD6FziV2UCsmROa9ku7AoBZCagnsJjpk4Vh22q8327UHD31a3Cf3AAKj3ovhGu ctcjIRR/zfddHo41S1xFqWHp9PLyk//ph9MRjJgXuehvH9SL/E/nWfsPg/hEo2bsQDcO TmW3rxsbG0zEcLvsIN7Uht86NirJTPCs6B4hq0Fb97dqHCQtjcVcyXY5qNx0jyMK7kRN KKTo4mhtdli+eFDKT/fRdB3w9/mV8wa3hUgmy8shokWWuWWLjpOBLdnOsG+Ew4+mqG8u mA1ZDfGoinbN8RIcHxvOENo3YtmuhjHlMKD4Oe9p6wDblZfYBiyCkxWF85m23aFv4xlu G9gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=5F/oxoaNwFenWfg08tNUegoOEfFql+LkieCTkIBTIfs=; b=XbqRNUFTIYADlOu6XGGwpB8EGClBCAZS+j068NlQsXmeHvJv3V1694Mmbg/GnZ8rae 0nDhIy2O/2SjsojD6Q0181KlbxWcqFpEiNLjlqsUcZIHjmZzhuDolTBwiioQ/QgcVxZT 6ILJbwsB5vqzNtpBxkwUcQxOMN5Q2jIxay60vEUSKxYO4AsUbEopVIxMWYkiVsmVvQ2m vgp1EAQUK7aN+nEYGdeR7AFVOpnwEsgyOlKWziP8ZtCRtmMmldCVIr7xr1DxXCnSO3Xa B+R7PrlEhgOKT1IcWkHaOwL25Pw2IR5Yl+TCv3rdrx2By0Ygg2VwS67eD8cT6v5zsTvs GCfA== X-Gm-Message-State: AKGB3mIomBxlW0dO3vJk5ZGyl62fpqH6LdB+51fAhj3xx85qXjD5TLWK Yod63kpda5lmePZ6IMfiIVs= X-Google-Smtp-Source: ACJfBotmGz3db7n00Eco+/2IyxtH+cBcuLvNvdLdE6bFFVUQ3UsyxknA1+pHB1Uol7iP4hpymDtbmQ== X-Received: by 10.223.134.249 with SMTP id 54mr1836714wry.225.1514992256363; Wed, 03 Jan 2018 07:10:56 -0800 (PST) Received: from localhost.localdomain (bzq-166-168-31-246.red.bezeqint.net. [31.168.166.246]) by smtp.gmail.com with ESMTPSA id p90sm1241516wmf.3.2018.01.03.07.10.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 03 Jan 2018 07:10:55 -0800 (PST) From: Amir Goldstein To: Jeff Layton , "J . Bruce Fields" Cc: Miklos Szeredi , linux-unionfs@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: [RFC][PATCH 1/2] vfs: update overlay inode times on write Date: Wed, 3 Jan 2018 17:11:43 +0200 Message-Id: <1514992304-8021-2-git-send-email-amir73il@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1514992304-8021-1-git-send-email-amir73il@gmail.com> References: <1514992304-8021-1-git-send-email-amir73il@gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Currently with overlayfs, the real upper inode's i_mtime is updated on write, but not overlay vfs inode. The vfs inode's i_mtime is used by nfsd to check if nfs client cache is stale, so updating the overlay vfs inode i_mtime on write is required for overlayfs NFS export support. The non uptodate mtime issue was found and verified with the nfstest_posix test when run over NFS exported overlayfs: $ nfstest_posix --runtest=write ... FAIL: write - file st_mtime should be updated Signed-off-by: Amir Goldstein --- fs/inode.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/fs/inode.c b/fs/inode.c index 03102d6ef044..a252256f4e51 100644 --- a/fs/inode.c +++ b/fs/inode.c @@ -1567,8 +1567,7 @@ EXPORT_SYMBOL(bmap); /* * Update times in overlayed inode from underlying real inode */ -static void update_ovl_inode_times(struct dentry *dentry, struct inode *inode, - bool rcu) +static void update_ovl_d_inode_times(struct dentry *dentry, bool rcu) { struct dentry *upperdentry; @@ -1585,6 +1584,7 @@ static void update_ovl_inode_times(struct dentry *dentry, struct inode *inode, * stale mtime/ctime. */ if (upperdentry) { + struct inode *inode = d_inode(dentry); struct inode *realinode = d_inode(upperdentry); if ((!timespec_equal(&inode->i_mtime, &realinode->i_mtime) || @@ -1607,7 +1607,8 @@ static int relatime_need_update(const struct path *path, struct inode *inode, if (!(path->mnt->mnt_flags & MNT_RELATIME)) return 1; - update_ovl_inode_times(path->dentry, inode, rcu); + update_ovl_d_inode_times(path->dentry, rcu); + /* * Is mtime younger than atime? If yes, update atime: */ @@ -1876,6 +1877,8 @@ int file_update_time(struct file *file) ret = update_time(inode, &now, sync_it); __mnt_drop_write_file(file); + update_ovl_d_inode_times(file->f_path.dentry, false); + return ret; } EXPORT_SYMBOL(file_update_time);