From patchwork Mon Aug 27 12:56:04 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amir Goldstein X-Patchwork-Id: 10577075 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C3690920 for ; Mon, 27 Aug 2018 12:54:24 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B04C72943E for ; Mon, 27 Aug 2018 12:54:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A4DC529958; Mon, 27 Aug 2018 12:54:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.7 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RCVD_IN_SBL_CSS autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 53CAE2943E for ; Mon, 27 Aug 2018 12:54:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727354AbeH0Qkz (ORCPT ); Mon, 27 Aug 2018 12:40:55 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:36366 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727294AbeH0Qkz (ORCPT ); Mon, 27 Aug 2018 12:40:55 -0400 Received: by mail-wr1-f67.google.com with SMTP id m27-v6so13541902wrf.3; Mon, 27 Aug 2018 05:54:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=4qLxciv+NeYBOhSV7lYItD823fqJpeqTfUVsnT5UQn8=; b=XakwqXjPfqiztv9IWnm4tol76BDC5813Bqb6zAMSrUHx/aPGG9ClY2AC9uc3ZrxySA /Sb9TFOROt3SIsNRQOiQ1BlSp4ISP4XAr09Bp9CDJlg/TGsWmqtc64Iz7979GAvzX3En 6m3qeE/vFHSjHPgtsCZFFFy+P9SHGapo0um+3kpqhd//7cOv66in+H/ZiL5Itbq/OAJp 6Ft1+4Wz6XHY+x6gbAZlC5AXUi5UTc+yWorPBb25K8Cy3u+rRiCxTTzZCLd+j5gwAw2N QOwv/clJYGhu97wPuboVzRHaiytbGelQKIO95zZHPtJF7tz6RxjsaBIDbKI6cbHEgf8l rT7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=4qLxciv+NeYBOhSV7lYItD823fqJpeqTfUVsnT5UQn8=; b=dtgte4Jp5NROQRs118Xw1KZmsablTACg7dw5G/ztgcpNlXBgtDlvoFt96voqOJpeUp KGOZX/mb3OR+1J8nCW+/f9xZkckrrSG5ko25gS0C+0wzoNKE760Zo/mWhNl6S1I+R7BR zpjlAQAse76IlbWp+ES/2b00mpJyO1pDEIIEc96nEDlupn4gtIuC2Fx6Ky4FnQ+b1qQD mFCcpezAZBvE/DDnvlb+s4n5A4JGQ3Mr7fiv1dTj53cV/Rp5NANj/BE33zmNh1raYf75 xuBUacDa7zaeOx42iFDvcUtezkPZW5xywPvAOKxa+E85Ah5k/ITXejzjTk82OWG/2ms4 HEIw== X-Gm-Message-State: APzg51CgJgfSJUh7hOvJWRLpmfLYFJ4e8aARS7g7YA2X96M9l585uZPc 5Cn6qQOwuuYpqRFQbWRqgh4N74DS X-Google-Smtp-Source: ANB0VdbbqM4qdGB7xCD5et9oijXmf3BNyEyXcuAq1qek4jw4WTGIPk38wKxiMsL/zNHusR4NcqLG6g== X-Received: by 2002:adf:afd3:: with SMTP id y19-v6mr8535738wrd.176.1535374461260; Mon, 27 Aug 2018 05:54:21 -0700 (PDT) Received: from localhost.localdomain ([141.226.8.68]) by smtp.gmail.com with ESMTPSA id z14-v6sm8504046wma.18.2018.08.27.05.54.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 27 Aug 2018 05:54:20 -0700 (PDT) From: Amir Goldstein To: Miklos Szeredi Cc: Al Viro , Dave Chinner , linux-unionfs@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: [PATCH v3 6/6] ovl: add ovl_fadvise() Date: Mon, 27 Aug 2018 15:56:04 +0300 Message-Id: <1535374564-8257-7-git-send-email-amir73il@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1535374564-8257-1-git-send-email-amir73il@gmail.com> References: <1535374564-8257-1-git-send-email-amir73il@gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Implement stacked fadvise to fix syscalls readahead(2) and fadvise64(2) on an overlayfs file. Suggested-by: Miklos Szeredi Fixes: d1d04ef8572b ("ovl: stack file ops") Signed-off-by: Amir Goldstein --- fs/overlayfs/file.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/fs/overlayfs/file.c b/fs/overlayfs/file.c index a4acd84591d4..42d2d034d85c 100644 --- a/fs/overlayfs/file.c +++ b/fs/overlayfs/file.c @@ -331,6 +331,23 @@ static long ovl_fallocate(struct file *file, int mode, loff_t offset, loff_t len return ret; } +int ovl_fadvise(struct file *file, loff_t offset, loff_t len, int advice) +{ + struct fd real; + int ret; + + ret = ovl_real_fdget(file, &real); + if (ret) + return ret; + + /* XXX: do we need mounter credentials? */ + ret = vfs_fadvise(real.file, offset, len, advice); + + fdput(real); + + return ret; +} + static long ovl_real_ioctl(struct file *file, unsigned int cmd, unsigned long arg) { @@ -499,6 +516,7 @@ const struct file_operations ovl_file_operations = { .fsync = ovl_fsync, .mmap = ovl_mmap, .fallocate = ovl_fallocate, + .fadvise = ovl_fadvise, .unlocked_ioctl = ovl_ioctl, .compat_ioctl = ovl_compat_ioctl,