From patchwork Mon Aug 27 15:29:19 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kirill Tkhai X-Patchwork-Id: 10577367 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 84296920 for ; Mon, 27 Aug 2018 15:29:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7205A29691 for ; Mon, 27 Aug 2018 15:29:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 655992968D; Mon, 27 Aug 2018 15:29:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EC7FB2968D for ; Mon, 27 Aug 2018 15:29:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727124AbeH0TQe (ORCPT ); Mon, 27 Aug 2018 15:16:34 -0400 Received: from mail-he1eur01on0139.outbound.protection.outlook.com ([104.47.0.139]:38752 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727014AbeH0TQe (ORCPT ); Mon, 27 Aug 2018 15:16:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G30o8RDpKGoI9zWPlvwHTDFaFafrCTLqiPwzWWktkTM=; b=Pa3PnrJQFTJ82Q/WUwiyx2U57+K3z2E5jA61MYiHg8EF/6+EBGZxo5MgSkWQPh4dvDTZ98S48oVD3pRTO4WEs14Hi8Mrxtpg2Mv+BqdvYPDZ4kfZP4sHauckDI8v8I42e2Ar/8J3r/rPXWrjBXtAkgI1yAWohpuYPoZTA0XVDWc= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=ktkhai@virtuozzo.com; Received: from localhost.localdomain (185.231.240.5) by HE1PR0801MB2027.eurprd08.prod.outlook.com (2603:10a6:3:50::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1080.15; Mon, 27 Aug 2018 15:29:23 +0000 Subject: [PATCH 2/6] fuse: Move clear_bit() up in request_end() From: Kirill Tkhai To: miklos@szeredi.hu, ktkhai@virtuozzo.com, linux-fsdevel@vger.kernel.org Date: Mon, 27 Aug 2018 18:29:19 +0300 Message-ID: <153538375956.18303.16994686498035052815.stgit@localhost.localdomain> In-Reply-To: <153538208536.18303.10732945923322972743.stgit@localhost.localdomain> References: <153538208536.18303.10732945923322972743.stgit@localhost.localdomain> User-Agent: StGit/0.18 MIME-Version: 1.0 X-Originating-IP: [185.231.240.5] X-ClientProxiedBy: DB6P193CA0014.EURP193.PROD.OUTLOOK.COM (2603:10a6:6:29::24) To HE1PR0801MB2027.eurprd08.prod.outlook.com (2603:10a6:3:50::16) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a46b5beb-d121-41de-cb6b-08d60c31de0b X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(7020095)(4652040)(8989137)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(2017052603328)(7153060)(7193020);SRVR:HE1PR0801MB2027; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB2027;3:g5z5dsNGjGrOT3fkM0qYx3jsQW+vsxgUI8ip2/K64+Q89+Sg2NoWHz8MZlRxq8eIP14+/ixOKJ2RfR64k++oJu+9wBmAwnB/xA+WCvzcYRnhUr7Nm92hP0GLjcOkjKSSXhRBP4L9Euyl8y47N/xk+NTeICYoJOyC0JsAjiKrotxW5InrUHMJL+j4rJdIvblwpzS19RbhldtZXUBV7IOVA4rPiunY61kCMi9SJ4c/DF6W3xOI70nzZKYEa7VthqAa;25:BPUsbsZ2+2y4FtMvr/xt7zpO08G4kTbup1M27ZpjNcB+M5xDpsww5oMvMalEYaBHp7551IGRZXQ+U1QJ2sfWG1fxSjv3gCQwLA5E2P6lmD/8wDTt/ZwVfyH/KG9J4xnwgMt3+0PrquNMmEPhwQyM1rWljBcXbtPdyd/0PClOnjfJ1KVGam3QNurZv+w6WyIxbBgT/Y/jdn0joNiJSBMel1lxO0hHoimSewI+RHoAuTs+O52nJBkNniNfLuhmOBe/I0aISkH9yGdWZzobPT3BK3MIyBqKu2uy3sQUuGCby77JPZgYCjnWfv4gWC+HH69L3/tIEZFyUr8VsRihi1GKuQ==;31:/9+plIvvj9JT03gLayktolgle5PfecfsS2DNuRACLDwWvEib8FrMIuAYwGxtqKPwnev/92NVOr1gqrMCMSHukZ+6jM6/u+Se/L2+eDroaMB0IuJ5UHmwG5KIg+YAxogkXLXskbjPR4mHXD6TL3JP/yP33Hp1jawWxxA98GbaTqwaXupgu/GkGg8ycMAgRvMwzDQbfoJGD8kuJFoJgddNY1tleIIKHFsSX2gavUlmQRA= X-MS-TrafficTypeDiagnostic: HE1PR0801MB2027: X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB2027;20:tWwY9/3vTr0qj9Da2btbW7uOt5bQvSknsN3x2bC7vO5ehe/6V7WAwEyjH+oNgH1Usk45ogwVPy94a2MDALfHtvNvFNZ9miOyXCVoLweLbWbJcpzAEQ5CUA0OTraWgCSD5huXFDudTnH7Plpyi8VKG06gRhdMrTCS/vJoWQxiFUiGU5fjL67G5OhJsdoAzXTVq21zGOVybjr+jDdjEcn44LMFTaU/liDlyTDZvSeAX7apxopLBUcDrY39DINDEkV6MZXIl+4vpFs75+nghFBZIVGHhBOh01691KXd/FZqEBZ+AiNOcGyG5PWRKG1rrx1U46mzcTH/sHE1cTyJA4cLyDNiMpa8kkffOzQQcS6nbWcHTgClIYRoBzXE52ddLWxlVkd5fl7pqO1h921M+PYIhTpAx2k2VFi96hJdE5qNzlRsiXIlgN5jbmoebPrZjM9qRevuyB+LQWbGPZLExVDBihpIRCUTCuNq0vSINKD29X4+dp2Nmip1RSL2A9d+WTTW;4:Q/4YOLz89ZR4F/23nId3UOCbgBIAAuIZlIt7LcyoHZBjNJ4ndXSqtZU4qeVCixghqzIBwa0BbRvadfnrUIT0R0Z3dtNz9KWJpOCtbybn/hKfzzlnqpXe4RB5IY/s5Vq3cB2AK/d9S+fBdt4Nzqr2uJ2wtGfOZGRdspI3z9BqqC1xy74EXvef8NJcf8d6Z7dXGTvBVLq+Vvkxn1iaLEfMc0SvWy1GZSeX7U/517XJXZn47nW70xo+eHnRfzz2aZ9RUE65gkVarsbtRrIBOMPcCA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040522)(2401047)(5005006)(8121501046)(3231311)(944501410)(52105095)(10201501046)(93006095)(93001095)(3002001)(149027)(150027)(6041310)(20161123564045)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(201708071742011)(7699016);SRVR:HE1PR0801MB2027;BCL:0;PCL:0;RULEID:;SRVR:HE1PR0801MB2027; X-Forefront-PRVS: 07778E4001 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6069001)(366004)(346002)(136003)(376002)(396003)(39850400004)(189003)(199004)(8936002)(106356001)(105586002)(50466002)(33896004)(76176011)(25786009)(68736007)(6506007)(386003)(2486003)(23676004)(26005)(52116002)(16526019)(7696005)(186003)(14444005)(81166006)(446003)(956004)(476003)(230700001)(486006)(305945005)(6116002)(3846002)(7736002)(11346002)(5660300001)(8676002)(478600001)(81156014)(6666003)(2906002)(53936002)(58126008)(316002)(55016002)(9686003)(103116003)(47776003)(86362001)(97736004)(66066001)(61506002);DIR:OUT;SFP:1102;SCL:1;SRVR:HE1PR0801MB2027;H:localhost.localdomain;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; Received-SPF: None (protection.outlook.com: virtuozzo.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?q?1=3BHE1PR0801MB2027=3B23=3A/OxfR?= =?utf-8?q?3d3wSsioNAhvaTm5uwVKfacYtwTJ8Xxg7xjzI83CaCf2I3ywiK1zbOFLVQd+VXWEk?= =?utf-8?q?eyjL2yBClanVvvAKA5My0vAoV1+3B32KvwV6yJbDfeq7h+20XrFFCcXA5UbIm3iC6?= =?utf-8?q?DPEEj1Q7mOZwl4senEaWJ7ov3UIi8LurK7+AKupVveeE9MWiuV/qVRTTOl23fPUC/?= =?utf-8?q?tfIkHIxbSfVbW/3umVv8OMV1djC2edsaLBTyzUacJWca9E/fMlYTZni2itFCIvcK5?= =?utf-8?q?xEcL9xH4GWPCUg99yhhtpQ4oWo+TRffEmycyrwRtkufIlifFQUqY4Ck2b02HcsN8I?= =?utf-8?q?yDBb65LlXeS1eWtilNCvFHUKwygbKhBSEzmPT2WLg3G9miOENLy+gGYrswT6KWCpm?= =?utf-8?q?0NIiWAhYzRmTHLWgQhm15lRmJJRZPRg+iwAOq/D6y/BnlfyDY2cgsZdYgC2tc54Y2?= =?utf-8?q?i0sFnMfxtDRqe1SG5Af8zaduImIVJxMiB2Hz073TdwrJ40uOS0i5TKSPKIfi7TGFJ?= =?utf-8?q?VUX7HKUJ3FXUf6T0mwMJ1QGxlYIEXBiRvmkbu44IE6+Dyj+iq73Ju38jexsqIfTqX?= =?utf-8?q?FYlFcngPkW4z8QOLvix93pX5pDmGygCOt7cb3aIYWFOWquIWsyxqFJ2oiyoYt6kA+?= =?utf-8?q?cxKawEo+LErkYLz7rvpqVivRDOi0DymZgLv32LOOLcCJXOLoPNOdyxh2MVKmRMNNG?= =?utf-8?q?YzymIast/nXIziafeTSVWqOFRSK8znv48ui/HYXRlrJT+xkM9TdZL5W6JtAu4VDb1?= =?utf-8?q?XxMqhrwMr7XtOj2s5GQFVfqKqy+vwDxp295J600YD9CreVEwOOl0VYiWwf0DtqEzQ?= =?utf-8?q?Z3jSd/NUuNIkdm2idqDsl1luHqjFMiGb4OMJFtyRTvLVeL5qH1nGdHvQSxoAA/CS4?= =?utf-8?q?CfGoaWn7ga/314U5U8ePUXmzhqJ8r6B2F7WnBjb8uzp0b0Y9yKi3JqdjJ6Iyl0mdI?= =?utf-8?q?7exhax+XhtcyWtg+Kh9GczGt/wWaURwEDGNt8ZiBCj9n2KppCb8A49n2PKJkmCDVS?= =?utf-8?q?10m3+1ozUJs37wsv+EjB+8wcqTStu84VT9BQGG/ZujLGJzqdDWggl/lpyl0p1KPxX?= =?utf-8?q?HAYbVKS2MfQBst+V3Uq71+JP+z3rp+pXdc0xXVVFuw0IAFDwf7ffsf5PQ1wZZVEim?= =?utf-8?q?KwX2Qd8WPBp08puzlI7e4Bn+l0pR8ZmlTHr0WgycF?= X-Microsoft-Antispam-Message-Info: 7x3xLrqHTXBNT787YAB5SSGJCBtga4SRvXSihEgxvYvGZ4YqW42EEWJMgdkHj+tHNdRpn6kCgfDIB3/p/GACLhVmlHjUyfZucfxlz7m6hZDSd1Uab/bXpOsiqlrGKzQEybJvfyS0oiBP/ysOunXnCMu960YyV94sOvMCZkoj7y2I8PGL/LHVtLWrFh1aMF05ERM6cEHHepJB+uJf+OW2/NgEEiIntettEIdVHzxfg6wCPcIEjZ737SlE2s2b/EP6xzZrns+9vyB970089Ej1P6QziqjwaGZaAVM0ULfBDxJQCmDuTLYSTVfl3/4TGOydhPRljeJlorEoggVc4NPk7i3oXJ3OZVD39IH3eCToSyo= X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB2027;6:v16QS8OwYUfkmdRNwJ8c7cKrpIlCVijHsCBs+anOLMbqKADJ2/dE2Tir1Dv2107ycJ7w2yojIJVGU8BRTy3Fa64MJaFhSiPE6f08jyXNm4zVWHOmOj7tjwe8TnNTieebnROuHpb7vnUfEy9HQM2Erug+VN3RHbcEv0Dq/KsRffu0QUBpoCmc2hMFFeD1nAUtT1ewSB86yPkeKE6TGC6dp9tasTKmkQGOOnaeopNq213emL2C6L1Y5/PyGq1vtTf7jVBnAXoEXZtW9fcNsU7cNwMmPHG9shKG4IYKR1jZLaq1VVrjWfzfz9Si+nvlfEMLOPkzuJdcFGjuqXbB69aGPASyvdNIwXOYv5QqDLilliNA9DZL5rJy708orGWv/xGutnz+yq8MgBYrouiMwA9AK+NFDBmiwbB8Ia8ukSUR0h6cWg1epkh8Zj8qzDLj9Xxe+PQ1gc2gA2vgO1T7FifLiA==;5:7JIkILj04NcFsAWqw5wNR4t/a2+E+x8pdBK43GBnvYIlSooD/h4rDjhim3AjHzK0FEJHc66Y41WBIqxOlpGwdKek710ZQUOmx8E19uryf1it2tj1gXkY5Fc6wD21h1dm0HcP1k6aQ0Cb3ezirnvZhEhPi3smjR44v8mje720beY=;7:EdwNol3aQIwQLBWxKX9gkCwk2S3yMnbeKMaBA5Y/wl4xE19HZgBzdYJ7xq3JUq0LacyvAe6OVLqRkeV0AYa1labgURX/RjBRu0Zz33IMvpaEu2rg2pPfNazOiXhR/DyPmeRkpCjZNQpFpPc3qx0fccK001G7Pm9uK6bY0YCtn2NmncXfIEeL6fvD3d56cBG30ZldRiF3JBk5lcvxkNpTjwpr2bMf0PLc6kUewpGMCc7t1wFR7Htj0c1UkYg7O0Xj SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB2027;20:tBGCyqm0ZD3KYDh5ewhvpD37fMZ6LF3xBpBOofxqr5j38rOCIaqR2fIYMXi8dDBoXYjyXoPznRT/6YTDRYsqGyrnvyAn+VJGw35NYLIgi1oQtPB5SqIsKBANgVO2nwglyM9ugydCWftcM7i2Rz+0r/p/oB+TQtG/0EiN4zmMZmk= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Aug 2018 15:29:23.2154 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a46b5beb-d121-41de-cb6b-08d60c31de0b X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB2027 Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Nobody can clear FR_BACKGROUND bit on processing request in parallel, so it's possible to do it out of fc->lock. Signed-off-by: Kirill Tkhai --- fs/fuse/dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c index 214ce96b1d26..ce07a41ff8fe 100644 --- a/fs/fuse/dev.c +++ b/fs/fuse/dev.c @@ -390,8 +390,8 @@ static void request_end(struct fuse_conn *fc, struct fuse_req *req) WARN_ON(test_bit(FR_PENDING, &req->flags)); WARN_ON(test_bit(FR_SENT, &req->flags)); if (test_bit(FR_BACKGROUND, &req->flags)) { - spin_lock(&fc->lock); clear_bit(FR_BACKGROUND, &req->flags); + spin_lock(&fc->lock); if (fc->num_background == fc->max_background) fc->blocked = 0;