From patchwork Fri Oct 5 00:19:20 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Darrick J. Wong" X-Patchwork-Id: 10627067 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id EC3E913BB for ; Fri, 5 Oct 2018 00:19:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DD4E6292FD for ; Fri, 5 Oct 2018 00:19:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C8230292FF; Fri, 5 Oct 2018 00:19:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F2A212930F for ; Fri, 5 Oct 2018 00:19:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727536AbeJEHPb (ORCPT ); Fri, 5 Oct 2018 03:15:31 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:56252 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726038AbeJEHPb (ORCPT ); Fri, 5 Oct 2018 03:15:31 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w950JB1x178608; Fri, 5 Oct 2018 00:19:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : from : to : cc : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=Brok3g4L1ihiKwrP/2mHS0BHbPhyCINB68uAbS0m9rA=; b=4mKcuaG08b3xxqKnwMwCj5nZyywCbMxd2tDAu8l3EXiW8S1vrx1qnRziX1KEMu4BHNh2 Zjdu1WHS+qvY7dv101LedgbXi+D6/AplmZX0cp6E+IwIR636Uj7MFmFMUiT6gUlFBCKu umSDkXwT6lWCmSk18EqwpSo+oIh1lXZY5pU8CCjIfVkOmgh566bjfIsEUcQZ3fWrzGV5 985xm/pUzbS7CzpH+arYGLnwQvXlOtmw85PLgvbke/Q5tOczpOhRuCVZolBNLD1XW9ky 2gKbpLnrrrPDgvcV8a8nVF5/vy7RSVoF6xSYgLCZkS7cpQUmR9hGX0P1cGntUBPeZMq2 Uw== Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp2120.oracle.com with ESMTP id 2mt21rfgx9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 05 Oct 2018 00:19:28 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w950JMrM004413 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 5 Oct 2018 00:19:22 GMT Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w950JLeq008335; Fri, 5 Oct 2018 00:19:22 GMT Received: from localhost (/67.169.218.210) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 05 Oct 2018 00:19:21 +0000 Subject: [PATCH 2/6] xfs: test mount time summary counter check and fix From: "Darrick J. Wong" To: guaneryu@gmail.com, darrick.wong@oracle.com Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, fstests@vger.kernel.org Date: Thu, 04 Oct 2018 17:19:20 -0700 Message-ID: <153869876040.26648.11302951509500617148.stgit@magnolia> In-Reply-To: <153869874763.26648.516233620615833277.stgit@magnolia> References: <153869874763.26648.516233620615833277.stgit@magnolia> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9036 signatures=668706 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=2 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1810050002 Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Darrick J. Wong Tests to ensure that the xfs mount code can detect obviously bad fs summary counters at mount time and fix them. Signed-off-by: Darrick J. Wong --- tests/xfs/722 | 58 +++++++++++++++++++++++++++++++++++++++++++++++ tests/xfs/722.out | 4 +++ tests/xfs/723 | 58 +++++++++++++++++++++++++++++++++++++++++++++++ tests/xfs/723.out | 4 +++ tests/xfs/724 | 66 +++++++++++++++++++++++++++++++++++++++++++++++++++++ tests/xfs/724.out | 4 +++ tests/xfs/group | 3 ++ 7 files changed, 197 insertions(+) create mode 100755 tests/xfs/722 create mode 100644 tests/xfs/722.out create mode 100755 tests/xfs/723 create mode 100644 tests/xfs/723.out create mode 100755 tests/xfs/724 create mode 100644 tests/xfs/724.out diff --git a/tests/xfs/722 b/tests/xfs/722 new file mode 100755 index 00000000..1012bd58 --- /dev/null +++ b/tests/xfs/722 @@ -0,0 +1,58 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2018 Oracle. All Rights Reserved. +# +# FS QA Test 722 +# +# Test detection & fixing of bad summary block counts at mount time. +# +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap '_cleanup; exit $status' 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# remove previous $seqres.full before test +rm -f $seqres.full + +# real QA test starts here + +# Modify as appropriate. +_supported_fs xfs +_supported_os Linux +_require_scratch + +echo "Format and mount" +_scratch_mkfs > $seqres.full 2>&1 +_scratch_mount >> $seqres.full 2>&1 +echo "test file" > $SCRATCH_MNT/testfile + +echo "Fuzz fdblocks" +_scratch_unmount +dblocks=$(_scratch_xfs_get_metadata_field dblocks 'sb 0') +_scratch_xfs_set_metadata_field fdblocks $((dblocks * 2)) 'sb 0' > $seqres.full 2>&1 + +echo "Detection and Correction" +_scratch_mount >> $seqres.full 2>&1 +avail=$(stat -c '%a' -f $SCRATCH_MNT) +total=$(stat -c '%b' -f $SCRATCH_MNT) +echo "avail: $avail" >> $seqres.full +echo "total: $total" >> $seqres.full +test "$avail" -gt "$total" && echo "free space bad: $avail > $total" + +# success, all done +status=0 +exit diff --git a/tests/xfs/722.out b/tests/xfs/722.out new file mode 100644 index 00000000..8d1327b7 --- /dev/null +++ b/tests/xfs/722.out @@ -0,0 +1,4 @@ +QA output created by 722 +Format and mount +Fuzz fdblocks +Detection and Correction diff --git a/tests/xfs/723 b/tests/xfs/723 new file mode 100755 index 00000000..c068e496 --- /dev/null +++ b/tests/xfs/723 @@ -0,0 +1,58 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2018 Oracle. All Rights Reserved. +# +# FS QA Test 723 +# +# Test detection & fixing of bad summary inode counts at mount time. +# +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap '_cleanup; exit $status' 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# remove previous $seqres.full before test +rm -f $seqres.full + +# real QA test starts here + +# Modify as appropriate. +_supported_fs xfs +_supported_os Linux +_require_scratch + +echo "Format and mount" +_scratch_mkfs > $seqres.full 2>&1 +_scratch_mount >> $seqres.full 2>&1 +echo "test file" > $SCRATCH_MNT/testfile + +echo "Fuzz ifree" +_scratch_unmount +icount=$(_scratch_xfs_get_metadata_field icount 'sb 0') +_scratch_xfs_set_metadata_field ifree $((icount * 2)) 'sb 0' > $seqres.full 2>&1 + +echo "Detection and Correction" +_scratch_mount >> $seqres.full 2>&1 +avail=$(stat -c '%d' -f $SCRATCH_MNT) +total=$(stat -c '%c' -f $SCRATCH_MNT) +echo "avail: $avail" >> $seqres.full +echo "total: $total" >> $seqres.full +test "$avail" -gt "$total" && echo "free inodes bad: $avail > $total" + +# success, all done +status=0 +exit diff --git a/tests/xfs/723.out b/tests/xfs/723.out new file mode 100644 index 00000000..e825855a --- /dev/null +++ b/tests/xfs/723.out @@ -0,0 +1,4 @@ +QA output created by 723 +Format and mount +Fuzz ifree +Detection and Correction diff --git a/tests/xfs/724 b/tests/xfs/724 new file mode 100755 index 00000000..f5e44fb6 --- /dev/null +++ b/tests/xfs/724 @@ -0,0 +1,66 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2018 Oracle. All Rights Reserved. +# +# FS QA Test 724 +# +# Test detection & fixing of bad summary block counts at mount time. +# Corrupt the AGFs to test mount failure when mount-fixing fails. +# +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap '_cleanup; exit $status' 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# remove previous $seqres.full before test +rm -f $seqres.full + +# real QA test starts here + +# Modify as appropriate. +_supported_fs xfs +_supported_os Linux +_require_scratch_nocheck + +echo "Format and mount" +_scratch_mkfs > $seqres.full 2>&1 +_scratch_mount >> $seqres.full 2>&1 +echo "test file" > $SCRATCH_MNT/testfile + +echo "Fuzz fdblocks and btreeblks" +_scratch_unmount +dblocks=$(_scratch_xfs_get_metadata_field dblocks 'sb 0') +_scratch_xfs_set_metadata_field fdblocks $((dblocks * 2)) 'sb 0' > $seqres.full 2>&1 + +aglen=$(_scratch_xfs_get_metadata_field length 'agf 0') +_scratch_xfs_set_metadata_field btreeblks $aglen 'agf 0' > $seqres.full 2>&1 + +echo "Detection and Correction" +if _try_scratch_mount >> $seqres.full 2>&1; then + echo "mount should have failed" + avail=$(stat -c '%a' -f $SCRATCH_MNT) + total=$(stat -c '%b' -f $SCRATCH_MNT) + echo "avail: $avail" >> $seqres.full + echo "total: $total" >> $seqres.full + test "$avail" -gt "$total" && echo "free space bad: $avail > $total" + _scratch_unmount +fi +_scratch_xfs_repair -n >> $seqres.full 2>&1 && echo "repair didn't find fuzz?" + +# success, all done +status=0 +exit diff --git a/tests/xfs/724.out b/tests/xfs/724.out new file mode 100644 index 00000000..6571f9ed --- /dev/null +++ b/tests/xfs/724.out @@ -0,0 +1,4 @@ +QA output created by 724 +Format and mount +Fuzz fdblocks and btreeblks +Detection and Correction diff --git a/tests/xfs/group b/tests/xfs/group index 821bf2ac..28074f07 100644 --- a/tests/xfs/group +++ b/tests/xfs/group @@ -488,3 +488,6 @@ 488 dangerous_fuzzers dangerous_norepair 489 dangerous_fuzzers dangerous_norepair 490 auto quick +722 auto quick fuzz +723 auto quick fuzz +724 auto quick fuzz