@@ -55,6 +55,12 @@
* inode_hash_lock
*/
+struct inode_isolate_control {
+ struct list_head *freeable;
+ struct mem_cgroup *memcg; /* derived from shrink_control */
+ bool memcg_low_reclaim; /* derived from scan_control */
+};
+
static unsigned int i_hash_mask __read_mostly;
static unsigned int i_hash_shift __read_mostly;
static struct hlist_head *inode_hashtable __read_mostly;
@@ -714,6 +720,59 @@ int invalidate_inodes(struct super_block *sb, bool kill_dirty)
return busy;
}
+#ifdef CONFIG_MEMCG_KMEM
+/*
+ * Once an inode is freed, all its belonging page caches will be dropped as
+ * well, even if there're lots of page caches. So if we intend to protect
+ * page caches in a memcg, we must protect their host(the inode) first.
+ * Otherwise the memcg protection can be easily bypassed with freeing inode,
+ * especially if there're big files in this memcg.
+ * Note that it may happen that the page caches are already charged to the
+ * memcg, but the inode hasn't been added to this memcg yet. In this case,
+ * this inode is not protected.
+ * The inherent mismatch between memcg and inode is a trouble. One inode
+ * can be shared by different MEMCGs, but it is a very rare case. If
+ * an inode is shared, its belonging page caches may be charged to
+ * different MEMCGs. Currently there's no perfect solution to fix this
+ * kind of issue, but the inode majority-writer ownership switching can
+ * help it more or less.
+ */
+static bool memcg_can_reclaim_inode(struct inode *inode,
+ struct inode_isolate_control *iic)
+{
+ unsigned long protection;
+ struct mem_cgroup *memcg;
+ bool reclaimable = true;
+
+ if (!inode->i_data.nrpages)
+ goto out;
+
+ /* Excludes freeing inode via drop_caches */
+ if (!current->reclaim_state)
+ goto out;
+
+ memcg = iic->memcg;
+ if (!memcg || memcg == root_mem_cgroup)
+ goto out;
+
+ protection = mem_cgroup_protection(memcg, iic->memcg_low_reclaim);
+ if (!protection)
+ goto out;
+
+ if (inode->i_data.nrpages)
+ reclaimable = false;
+
+out:
+ return reclaimable;
+}
+#else /* CONFIG_MEMCG_KMEM */
+static bool memcg_can_reclaim_inode(struct inode *inode,
+ struct inode_isolate_control *iic)
+{
+ return true;
+}
+#endif /* CONFIG_MEMCG_KMEM */
+
/*
* Isolate the inode from the LRU in preparation for freeing it.
*
@@ -732,8 +791,9 @@ int invalidate_inodes(struct super_block *sb, bool kill_dirty)
static enum lru_status inode_lru_isolate(struct list_head *item,
struct list_lru_one *lru, spinlock_t *lru_lock, void *arg)
{
- struct list_head *freeable = arg;
- struct inode *inode = container_of(item, struct inode, i_lru);
+ struct inode_isolate_control *iic = arg;
+ struct list_head *freeable = iic->freeable;
+ struct inode *inode = container_of(item, struct inode, i_lru);
/*
* we are inverting the lru lock/inode->i_lock here, so use a trylock.
@@ -742,6 +802,11 @@ static enum lru_status inode_lru_isolate(struct list_head *item,
if (!spin_trylock(&inode->i_lock))
return LRU_SKIP;
+ if (!memcg_can_reclaim_inode(inode, iic)) {
+ spin_unlock(&inode->i_lock);
+ return LRU_ROTATE;
+ }
+
/*
* Referenced or dirty inodes are still in use. Give them another pass
* through the LRU as we canot reclaim them now.
@@ -799,9 +864,14 @@ long prune_icache_sb(struct super_block *sb, struct shrink_control *sc)
{
LIST_HEAD(freeable);
long freed;
+ struct inode_isolate_control iic = {
+ .freeable = &freeable,
+ .memcg = sc->memcg,
+ .memcg_low_reclaim = sc->memcg_low_reclaim,
+ };
freed = list_lru_shrink_walk(&sb->s_inode_lru, sc,
- inode_lru_isolate, &freeable);
+ inode_lru_isolate, &iic);
dispose_list(&freeable);
return freed;
}
On my server there're some running MEMCGs protected by memory.{min, low}, but I found the usage of these MEMCGs abruptly became very small, which were far less than the protect limit. It confused me and finally I found that was because of inode stealing. Once an inode is freed, all its belonging page caches will be dropped as well, no matter how may page caches it has. So if we intend to protect the page caches in a memcg, we must protect their host (the inode) first. Otherwise the memcg protection can be easily bypassed with freeing inode, especially if there're big files in this memcg. Supposes we have a memcg, and the stat of this memcg is, memory.current = 1024M memory.min = 512M And in this memcg there's a inode with 800M page caches. Once this memcg is scanned by kswapd or other regular reclaimers, kswapd <<<< It can be either of the regular reclaimers. shrink_node_memcgs switch (mem_cgroup_protected()) <<<< Not protected case MEMCG_PROT_NONE: <<<< Will scan this memcg beak; shrink_lruvec() <<<< Reclaim the page caches shrink_slab() <<<< It may free this inode and drop all its page caches(800M). So we must protect the inode first if we want to protect page caches. Note that this inode may be a cold inode (in the tail of list lru), because memcg protection protects all slabs and page cache pages whatever they are cold or hot. IOW, this is a memcg-protection-specific issue. The inherent mismatch between memcg and inode is a trouble. One inode can be shared by different MEMCGs, but it is a very rare case. If an inode is shared, its belonging page caches may be charged to different MEMCGs. Currently there's no perfect solution to fix this kind of issue, but the inode majority-writer ownership switching can help it more or less. Cc: Dave Chinner <dchinner@redhat.com> Cc: Johannes Weiner <hannes@cmpxchg.org> Signed-off-by: Yafang Shao <laoar.shao@gmail.com> --- fs/inode.c | 76 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 73 insertions(+), 3 deletions(-)