| Message ID | 159171921360.3038039.10494245358653942664.stgit@warthog.procyon.org.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | afs: Fixes | expand |
On Tue, Jun 09, 2020 at 05:13:33PM +0100, David Howells wrote: > Fix a couple of %px to be %x in debugging statements. > > Fixes: e49c7b2f6de7 ("afs: Build an abstraction around an "operation" concept") > Fixes: 8a070a964877 ("afs: Detect cell aliases 1 - Cells with root volumes") > Reported-by: Kees Cook <keescook@chromium.org> > Signed-off-by: David Howells <dhowells@redhat.com> Reviewed-by: Kees Cook <keescook@chromium.org> Thanks!
On Tue, Jun 9, 2020 at 1:13 PM David Howells <dhowells@redhat.com> wrote: > > Fix a couple of %px to be %x in debugging statements. > Nothing critical, but as in the patch subject this should be "%px to be %p", not %x. Marc
diff --git a/fs/afs/dir.c b/fs/afs/dir.c index 25cbe0aeeec5..aa1d34141ea3 100644 --- a/fs/afs/dir.c +++ b/fs/afs/dir.c @@ -980,7 +980,7 @@ static struct dentry *afs_lookup(struct inode *dir, struct dentry *dentry, if (!IS_ERR_OR_NULL(inode)) fid = AFS_FS_I(inode)->fid; - _debug("splice %px", dentry->d_inode); + _debug("splice %p", dentry->d_inode); d = d_splice_alias(inode, dentry); if (!IS_ERR_OR_NULL(d)) { d->d_fsdata = dentry->d_fsdata; diff --git a/fs/afs/vl_alias.c b/fs/afs/vl_alias.c index 136fc6164e00..5082ef04e99c 100644 --- a/fs/afs/vl_alias.c +++ b/fs/afs/vl_alias.c @@ -28,7 +28,7 @@ static struct afs_volume *afs_sample_volume(struct afs_cell *cell, struct key *k }; volume = afs_create_volume(&fc); - _leave(" = %px", volume); + _leave(" = %p", volume); return volume; }
Fix a couple of %px to be %x in debugging statements. Fixes: e49c7b2f6de7 ("afs: Build an abstraction around an "operation" concept") Fixes: 8a070a964877 ("afs: Detect cell aliases 1 - Cells with root volumes") Reported-by: Kees Cook <keescook@chromium.org> Signed-off-by: David Howells <dhowells@redhat.com> --- fs/afs/dir.c | 2 +- fs/afs/vl_alias.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)