| Message ID | 1611216753-44598-1-git-send-email-abaci-bugfix@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | vmalloc: remove redundant NULL check | expand |
On 01/21/21 at 04:12pm, Yang Li wrote: > Fix below warnings reported by coccicheck: > ./fs/proc/vmcore.c:1503:2-7: WARNING: NULL check before some freeing > functions is not needed. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Yang Li <abaci-bugfix@linux.alibaba.com> > --- > fs/proc/vmcore.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/fs/proc/vmcore.c b/fs/proc/vmcore.c > index c3a345c..9a15334 100644 > --- a/fs/proc/vmcore.c > +++ b/fs/proc/vmcore.c > @@ -1503,11 +1503,8 @@ int vmcore_add_device_dump(struct vmcoredd_data *data) > return 0; > > out_err: > - if (buf) > - vfree(buf); > - > - if (dump) > - vfree(dump); > + vfree(buf); > + vfree(dump); Looks good, thx. Acked-by: Baoquan He <bhe@redhat.com> Thanks Baoquan
diff --git a/fs/proc/vmcore.c b/fs/proc/vmcore.c index c3a345c..9a15334 100644 --- a/fs/proc/vmcore.c +++ b/fs/proc/vmcore.c @@ -1503,11 +1503,8 @@ int vmcore_add_device_dump(struct vmcoredd_data *data) return 0; out_err: - if (buf) - vfree(buf); - - if (dump) - vfree(dump); + vfree(buf); + vfree(dump); return ret; }
Fix below warnings reported by coccicheck: ./fs/proc/vmcore.c:1503:2-7: WARNING: NULL check before some freeing functions is not needed. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Yang Li <abaci-bugfix@linux.alibaba.com> --- fs/proc/vmcore.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)