From patchwork Fri Aug 4 05:33:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Kent X-Patchwork-Id: 13341284 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D86B1C001DB for ; Fri, 4 Aug 2023 05:40:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231160AbjHDFkP (ORCPT ); Fri, 4 Aug 2023 01:40:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231835AbjHDFkK (ORCPT ); Fri, 4 Aug 2023 01:40:10 -0400 Received: from smtp01.aussiebb.com.au (smtp01.aussiebb.com.au [121.200.0.92]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97688E46; Thu, 3 Aug 2023 22:40:05 -0700 (PDT) Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp01.aussiebb.com.au (Postfix) with ESMTP id 6CB371015A9; Fri, 4 Aug 2023 15:33:19 +1000 (AEST) X-Virus-Scanned: Debian amavisd-new at smtp01.aussiebb.com.au Received: from smtp01.aussiebb.com.au ([127.0.0.1]) by localhost (smtp01.aussiebb.com.au [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3WRgSlxFvley; Fri, 4 Aug 2023 15:33:19 +1000 (AEST) Received: by smtp01.aussiebb.com.au (Postfix, from userid 116) id 61AD71015A4; Fri, 4 Aug 2023 15:33:19 +1000 (AEST) Received: from donald.themaw.net (2403-580e-4b40-0-7968-2232-4db8-a45e.ip6.aussiebb.net [IPv6:2403:580e:4b40:0:7968:2232:4db8:a45e]) by smtp01.aussiebb.com.au (Postfix) with ESMTP id 746C2101592; Fri, 4 Aug 2023 15:33:18 +1000 (AEST) Subject: [PATCH 2/2] autofs: use wake_up() instead of wake_up_interruptible(() From: Ian Kent To: Al Viro , Christian Brauner Cc: autofs mailing list , linux-fsdevel , Kernel Mailing List , Fedor Pchelkin , Takeshi Misawa , Alexey Khoroshilov , Matthew Wilcox , Andrey Vagin Date: Fri, 04 Aug 2023 13:33:18 +0800 Message-ID: <169112719813.7590.4971499386839952992.stgit@donald.themaw.net> In-Reply-To: <169112719161.7590.6700123246297365841.stgit@donald.themaw.net> References: <169112719161.7590.6700123246297365841.stgit@donald.themaw.net> User-Agent: StGit/1.5 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org In autofs_wait_release() wake_up() is used to wake up processes waiting on a mount callback to complete which matches the wait_event_killable() in autofs_wait(). But in autofs_catatonic_mode() the wake_up_interruptible() was not also changed at the time autofs_wait_release() was changed. Signed-off-by: Ian Kent --- fs/autofs/waitq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/autofs/waitq.c b/fs/autofs/waitq.c index efdc76732fae..33dd4660d82f 100644 --- a/fs/autofs/waitq.c +++ b/fs/autofs/waitq.c @@ -32,7 +32,7 @@ void autofs_catatonic_mode(struct autofs_sb_info *sbi) wq->status = -ENOENT; /* Magic is gone - report failure */ kfree(wq->name.name - wq->offset); wq->name.name = NULL; - wake_up_interruptible(&wq->queue); + wake_up(&wq->queue); if (!--wq->wait_ctr) kfree(wq); wq = nwq;