From patchwork Fri Jan 23 11:13:04 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kirill A . Shutemov" X-Patchwork-Id: 5692981 Return-Path: X-Original-To: patchwork-linux-fsdevel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 0E18A9F302 for ; Fri, 23 Jan 2015 11:14:00 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0CD3B20123 for ; Fri, 23 Jan 2015 11:13:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0A95C2011E for ; Fri, 23 Jan 2015 11:13:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753664AbbAWLN3 (ORCPT ); Fri, 23 Jan 2015 06:13:29 -0500 Received: from mta-out1.inet.fi ([62.71.2.195]:36793 "EHLO jenni1.inet.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751795AbbAWLN2 (ORCPT ); Fri, 23 Jan 2015 06:13:28 -0500 Received: from node.shutemov.name (80.220.224.16) by jenni1.inet.fi (8.5.142.08) id 54BEDAE2004C7966; Fri, 23 Jan 2015 13:13:09 +0200 Received: by node.shutemov.name (Postfix, from userid 1000) id F1CA840343; Fri, 23 Jan 2015 13:13:04 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=shutemov.name; s=default; t=1422011585; bh=F7FKRACtWQ6E+wck+uX9xUHkXrdZcOODI7DreV+0Cgg=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=E7LUAU4UsfvhJN1d0IrZEiZ88kN+R8XbyiaHYvg6J3sCLJ2PgnVnt2cApnpU+2Ove Nj1GLDX1feUCxYkhF9Icm9XM7SkzbsvhrZknkYqbLPyGTtVx2SdCPSW+d8n/HzGR2s Z5EhkqefRSUN8GGqMeoCNgavtFhyng2ZHsW5eknU= Date: Fri, 23 Jan 2015 13:13:04 +0200 From: "Kirill A. Shutemov" To: Guenter Roeck Cc: akpm@linux-foundation.org, mm-commits@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-next@vger.kernel.org, sfr@canb.auug.org.au, mhocko@suse.cz, "Kirill A. Shutemov" Subject: Re: mmotm 2015-01-22-15-04: qemu failures due to 'mm: account pmd page tables to the process' Message-ID: <20150123111304.GA5975@node.dhcp.inet.fi> References: <54c1822d.RtdGfWPekQVAw8Ly%akpm@linux-foundation.org> <20150123050445.GA22751@roeck-us.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20150123050445.GA22751@roeck-us.net> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY, WEIRD_PORT autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Thu, Jan 22, 2015 at 09:04:45PM -0800, Guenter Roeck wrote: > On Thu, Jan 22, 2015 at 03:05:17PM -0800, akpm@linux-foundation.org wrote: > > The mm-of-the-moment snapshot 2015-01-22-15-04 has been uploaded to > > > > http://www.ozlabs.org/~akpm/mmotm/ > > > qemu:sh fails to shut down. > > bisect log: > > # bad: [03586ad04b2170ee816e6936981cc7cd2aeba129] pci: test for unexpectedly disabled bridges > # good: [ec6f34e5b552fb0a52e6aae1a5afbbb1605cc6cc] Linux 3.19-rc5 > git bisect start 'HEAD' 'v3.19-rc5' > # bad: [d113ba21d15c7d3615fd88490d1197615bb39fc0] mm: remove lock validation check for MADV_FREE > git bisect bad d113ba21d15c7d3615fd88490d1197615bb39fc0 > # good: [17351d1625a5030fa16f1346b77064c03b51f107] mm:add KPF_ZERO_PAGE flag for /proc/kpageflags > git bisect good 17351d1625a5030fa16f1346b77064c03b51f107 > # good: [ad18ad1fce6f241a9cbd4adfd6b16c9283181e39] memcg: add BUILD_BUG_ON() for string tables > git bisect good ad18ad1fce6f241a9cbd4adfd6b16c9283181e39 > # bad: [aa7e7cbfa43b74f6faef04ff730b5098544a4f77] mm/compaction: enhance tracepoint output for compaction begin/end > git bisect bad aa7e7cbfa43b74f6faef04ff730b5098544a4f77 > # good: [a40d0d2cf21e2714e9a6c842085148c938bf36ab] mm: memcontrol: remove unnecessary soft limit tree node test > git bisect good a40d0d2cf21e2714e9a6c842085148c938bf36ab > # good: [4ec4aa2e07c1d6eee61f6cace29401c6febcb6c5] mm: make FIRST_USER_ADDRESS unsigned long on all archs > git bisect good 4ec4aa2e07c1d6eee61f6cace29401c6febcb6c5 > # bad: [22310c209483224a64436a6e815a86feda681659] mm: account pmd page tables to the process > git bisect bad 22310c209483224a64436a6e815a86feda681659 > # good: [19a41261b1dcd8d12372d9c57c2035144608a599] arm: define __PAGETABLE_PMD_FOLDED for !LPAE > git bisect good 19a41261b1dcd8d12372d9c57c2035144608a599 > # first bad commit: [22310c209483224a64436a6e815a86feda681659] mm: account pmd page tables to the process > > --- > > qemu:microblaze generates warnings to the console. > > WARNING: CPU: 0 PID: 32 at mm/mmap.c:2858 exit_mmap+0x184/0x1a4() > > with various call stacks. See > http://server.roeck-us.net:8010/builders/qemu-microblaze-mmotm/builds/15/steps/qemubuildcommand/logs/stdio > for details. Could you try patch below? Completely untested. From b584bb8d493794f67484c0b57c161d61c02599bc Mon Sep 17 00:00:00 2001 From: "Kirill A. Shutemov" Date: Fri, 23 Jan 2015 13:08:26 +0200 Subject: [PATCH] microblaze: define __PAGETABLE_PMD_FOLDED Microblaze uses custom implementation of PMD folding, but doesn't define __PAGETABLE_PMD_FOLDED, which generic code expects to see. Let's fix it. Defining __PAGETABLE_PMD_FOLDED will drop out unused __pmd_alloc(). It also fixes problems with recently-introduced pmd accounting. Signed-off-by: Kirill A. Shutemov Reported-by: Guenter Roeck Tested-by: Guenter Roeck --- arch/microblaze/include/asm/pgtable.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/microblaze/include/asm/pgtable.h b/arch/microblaze/include/asm/pgtable.h index 46637bb090eb..e53b8532353c 100644 --- a/arch/microblaze/include/asm/pgtable.h +++ b/arch/microblaze/include/asm/pgtable.h @@ -61,6 +61,8 @@ extern int mem_init_done; #include +#define __PAGETABLE_PMD_FOLDED + #ifdef __KERNEL__ #ifndef __ASSEMBLY__