diff mbox

configfs: Fix potential NULL d_inode dereference

Message ID 20150127151839.31483.83547.stgit@warthog.procyon.org.uk (mailing list archive)
State New, archived
Headers show

Commit Message

David Howells Jan. 27, 2015, 3:18 p.m. UTC
Code that does this:

		if (!(d_unhashed(dentry) && dentry->d_inode)) {
			simple_unlink(parent->d_inode, dentry);

is broken because:

    !(d_unhashed(dentry) && dentry->d_inode)

is equivalent to:

    !d_unhashed(dentry) || !dentry->d_inode

so it is possible to get into simple_unlink() with dentry->d_inode == NULL.

simple_unlink(), however, assumes dentry->d_inode cannot be NULL.

I think that what was meant is this:

    !d_unhashed(dentry) && dentry->d_inode

and that the logical-not operator or the final close-bracket was misplaced.

Signed-off-by: David Howells <dhowells@redhat.com>
cc: Joel Becker <joel.becker@oracle.com>

 fs/configfs/inode.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox


diff --git a/fs/configfs/inode.c b/fs/configfs/inode.c
index 5946ad98053f..e5a7c18a9bee 100644
--- a/fs/configfs/inode.c
+++ b/fs/configfs/inode.c
@@ -249,7 +249,7 @@  void configfs_drop_dentry(struct configfs_dirent * sd, struct dentry * parent)
 	if (dentry) {
-		if (!(d_unhashed(dentry) && dentry->d_inode)) {
+		if (!d_unhashed(dentry) && dentry->d_inode) {