From patchwork Wed Aug 31 03:34:09 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Kent X-Patchwork-Id: 9306295 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id CAD9A60487 for ; Wed, 31 Aug 2016 03:35:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BE49A284A9 for ; Wed, 31 Aug 2016 03:35:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id AFE9628595; Wed, 31 Aug 2016 03:35:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5BBF0284A9 for ; Wed, 31 Aug 2016 03:35:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757955AbcHaDeW (ORCPT ); Tue, 30 Aug 2016 23:34:22 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:48267 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759020AbcHaDeT (ORCPT ); Tue, 30 Aug 2016 23:34:19 -0400 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 5D6E12045C; Tue, 30 Aug 2016 23:34:13 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute7.internal (MEProxy); Tue, 30 Aug 2016 23:34:13 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=themaw.net; h=cc :content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=MLK QWL0fNqveOGwVhoPrlk2ZhEY=; b=I4FS+rd4f8tlSMilJgK8qM6WxS/9TDf4dTL GzKjUdEii2vMJtNDkLzPLPjr/AedHdJYk5WkQrDf/MTvQqcC6NHpsBfoMLm1qw05 c7MQmsUpuHILXR8+tnpv5Hu418hqk1Kt+b5/yi3TyAqv3zm4oziGZDOk8yUnS+MG GlROKnn4= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=MLKQWL0fNqveOGwVhoPrlk2ZhEY=; b=Thwti idvNbeHdY8NGRtYiD6RkmCbEJZiCIZdiKH6t60h8+8ww03tHFeM20PDhh+YzDRP+ Uy3TEKuQez8sGadYQtHs3oQ7Fi636EcWeJPrE0HEns3qdAHmqlm+glT3d1/kytsf p6Jka06Pk7TJRs7fOjwC6S8D/+Xonk+QBykSFE= X-Sasl-enc: A3S4cXZI01rEMsOF6d3kq8hXj6sn58r/O2LoLpSc0FE3 1472614452 Received: from pluto.themaw.net (220-253-166-124.dyn.iinet.net.au [220.253.166.124]) by mail.messagingengine.com (Postfix) with ESMTPA id B1FF9CCE65; Tue, 30 Aug 2016 23:34:12 -0400 (EDT) Received: from pluto.themaw.net (localhost [127.0.0.1]) by pluto.themaw.net (Postfix) with ESMTP id E200DA007B; Wed, 31 Aug 2016 11:34:09 +0800 (AWST) Subject: [PATCH 1/3] autofs: remove possibly misleading /* #define DEBUG */ From: Ian Kent To: Andrew Morton Cc: linux-fsdevel , Tomohiro Kusumi , autofs mailing list , Kernel Mailing List Date: Wed, 31 Aug 2016 11:34:09 +0800 Message-ID: <20160831033409.9910.77067.stgit@pluto.themaw.net> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Tomohiro Kusumi Having this in autofs_i.h gives illusion that uncommenting this enables pr_debug(), but it doesn't enable all the pr_debug() in autofs because inclusion order matters. XFS has the same DEBUG macro in its core header fs/xfs/xfs.h, however XFS seems to have a rule to include this prior to other XFS headers as well as kernel headers. This is not the case with autofs, and DEBUG could be enabled via Makefile, so autofs should just get rid of this comment to make the code less confusing. It's a comment, so there is literally no functional difference. Signed-off-by: Tomohiro Kusumi Signed-off-by: Ian Kent --- fs/autofs4/autofs_i.h | 2 -- 1 file changed, 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/fs/autofs4/autofs_i.h b/fs/autofs4/autofs_i.h index dd71bd4..4404a22 100644 --- a/fs/autofs4/autofs_i.h +++ b/fs/autofs4/autofs_i.h @@ -34,8 +34,6 @@ #include #include -/* #define DEBUG */ - #ifdef pr_fmt #undef pr_fmt #endif