From patchwork Wed Sep 14 22:51:05 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ross Zwisler X-Patchwork-Id: 9332633 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 017E8607FD for ; Wed, 14 Sep 2016 22:51:11 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E6B042434C for ; Wed, 14 Sep 2016 22:51:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DAFAF28934; Wed, 14 Sep 2016 22:51:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 490DF2434C for ; Wed, 14 Sep 2016 22:51:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761682AbcINWvI (ORCPT ); Wed, 14 Sep 2016 18:51:08 -0400 Received: from mga11.intel.com ([192.55.52.93]:15072 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755275AbcINWvH (ORCPT ); Wed, 14 Sep 2016 18:51:07 -0400 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP; 14 Sep 2016 15:51:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,336,1470726000"; d="scan'208";a="1030128379" Received: from theros.lm.intel.com (HELO linux.intel.com) ([10.232.112.59]) by orsmga001.jf.intel.com with ESMTP; 14 Sep 2016 15:51:07 -0700 Date: Wed, 14 Sep 2016 16:51:05 -0600 From: Ross Zwisler To: Christoph Hellwig Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-nvdimm@ml01.01.org, ross.zwisler@linux.intel.com Subject: Re: [PATCH 12/12] ext2: use iomap to implement DAX Message-ID: <20160914225105.GB29323@linux.intel.com> Mail-Followup-To: Ross Zwisler , Christoph Hellwig , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-nvdimm@ml01.01.org References: <1473847291-18913-1-git-send-email-hch@lst.de> <1473847291-18913-13-git-send-email-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1473847291-18913-13-git-send-email-hch@lst.de> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Wed, Sep 14, 2016 at 12:01:31PM +0200, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig Now that ext2 is using IOMAP, we need to select FS_IOMAP when EXT2_FS is selected else we get a build error: fs/built-in.o: In function `ext2_dax_fault': /home/rzwisler/project/review/fs/ext2/file.c:112: undefined reference to `iomap_dax_fault' fs/built-in.o: In function `ext2_dax_write_iter': /home/rzwisler/project/review/fs/ext2/file.c:75: undefined reference to `iomap_dax_rw' fs/built-in.o: In function `ext2_dax_read_iter': /home/rzwisler/project/review/fs/ext2/file.c:45: undefined reference to `iomap_dax_rw' Makefile:949: recipe for target 'vmlinux' failed make: *** [vmlinux] Error 1 With the following patch squashed into this commit: Reviewed-by: Ross Zwisler --- From 9c084641049990339b40bfd52a0aebf300d896ea Mon Sep 17 00:00:00 2001 From: Ross Zwisler Date: Wed, 14 Sep 2016 16:48:36 -0600 Subject: [PATCH] ext2: build in FS_IOMAP support needed by ext2 Signed-off-by: Ross Zwisler --- fs/ext2/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/ext2/Kconfig b/fs/ext2/Kconfig index c634874e..3391f48 100644 --- a/fs/ext2/Kconfig +++ b/fs/ext2/Kconfig @@ -1,5 +1,6 @@ config EXT2_FS tristate "Second extended fs support" + select FS_IOMAP help Ext2 is a standard Linux file system for hard disks.