diff mbox

[-next] fs/affs: fix return value check in affs_get_parent()

Message ID 20170123141018.2331-1-weiyj.lk@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Wei Yongjun Jan. 23, 2017, 2:10 p.m. UTC
From: Wei Yongjun <weiyongjun1@huawei.com>

In case of error, the function affs_bread() returns NULL pointer
not ERR_PTR(). The IS_ERR() test in the return value check should
be replaced with NULL test.

Fixes: e393e82a7d09 ("fs/affs: make export work with cold dcache")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
 fs/affs/namei.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox


diff --git a/fs/affs/namei.c b/fs/affs/namei.c
index a3df8a6..96dd1d0 100644
--- a/fs/affs/namei.c
+++ b/fs/affs/namei.c
@@ -453,8 +453,8 @@  static struct dentry *affs_get_parent(struct dentry *child)
 	struct buffer_head *bh;
 	bh = affs_bread(child->d_sb, d_inode(child)->i_ino);
-	if (IS_ERR(bh))
-		return ERR_CAST(bh);
+	if (!bh)
+		return ERR_PTR(-EIO);
 	parent = affs_iget(child->d_sb,
 			   be32_to_cpu(AFFS_TAIL(child->d_sb, bh)->parent));