From patchwork Tue Feb 14 02:45:58 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Goldwyn Rodrigues X-Patchwork-Id: 9571045 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8F34060578 for ; Tue, 14 Feb 2017 02:46:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7D32425E13 for ; Tue, 14 Feb 2017 02:46:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7223D27FA6; Tue, 14 Feb 2017 02:46:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2F79D25E13 for ; Tue, 14 Feb 2017 02:46:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751371AbdBNCq2 (ORCPT ); Mon, 13 Feb 2017 21:46:28 -0500 Received: from mx2.suse.de ([195.135.220.15]:34187 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750943AbdBNCq2 (ORCPT ); Mon, 13 Feb 2017 21:46:28 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 214E9AAC7 for ; Tue, 14 Feb 2017 02:46:27 +0000 (UTC) From: Goldwyn Rodrigues To: linux-fsdevel@vger.kernel.org Cc: jack@suse.cz, Goldwyn Rodrigues Subject: [PATCH 2/7] noblocking aio: Return if cannot get hold of i_rwsem Date: Mon, 13 Feb 2017 20:45:58 -0600 Message-Id: <20170214024603.9563-3-rgoldwyn@suse.de> X-Mailer: git-send-email 2.10.2 In-Reply-To: <20170214024603.9563-1-rgoldwyn@suse.de> References: <20170214024603.9563-1-rgoldwyn@suse.de> Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Goldwyn Rodrigues A failure to lock i_rwsem would mean there is I/O being performed by another thread. So, let's bail. Signed-off-by: Goldwyn Rodrigues Reviewed-by: Christoph Hellwig --- mm/filemap.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/mm/filemap.c b/mm/filemap.c index d8d7df8..50cee70 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -2885,7 +2885,12 @@ ssize_t generic_file_write_iter(struct kiocb *iocb, struct iov_iter *from) struct inode *inode = file->f_mapping->host; ssize_t ret; - inode_lock(inode); + /* Don't sleep on inode rwsem */ + if (iocb->ki_flags & IOCB_NONBLOCKING) { + if (!inode_trylock(inode)) + return -EAGAIN; + } else + inode_lock(inode); ret = generic_write_checks(iocb, from); if (ret > 0) ret = __generic_file_write_iter(iocb, from);