From patchwork Sun May 28 09:48:07 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 9752247 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8280360249 for ; Sun, 28 May 2017 09:48:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 752A928446 for ; Sun, 28 May 2017 09:48:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6A18128458; Sun, 28 May 2017 09:48:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 18AA828446 for ; Sun, 28 May 2017 09:48:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751161AbdE1Js1 (ORCPT ); Sun, 28 May 2017 05:48:27 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:59464 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751011AbdE1Js0 (ORCPT ); Sun, 28 May 2017 05:48:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=References:In-Reply-To:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=kk4qknEs1V9VE+Ps5uQGznK9G+7GN5bWiwg33Eupvi0=; b=cnf+sLCM8l0tvMRnYIWUx5HIP 1aDq/zZGEVZur5hTNugVjxL6LXHgTO57UKJh0GyTCRl36AJ7zGnyZGxEj2I/JUQHVOrcPb50o8VbZ 18lEAKID+MGONRttRvvM2/Iu4D2wNNQmUoYY2qr8wEgZfRJZkotaILiO5jB+iUC8mvJzvfRk0M3Zb 4soCDjXm3vp9XWRb73/oBS9YvUGqpNzC43LvODXuW3bKN2IYmKD7ysZf9bSoTn7LOSanRaUoIZ95g gb18OUDGS32CuDSnyHYWnIq0C1Gj7CtxkgfeqH5Hi3WuXhn76EnlTqfHnjEEAu8r5dxRsVznb/VQb IR32Xa7AA==; Received: from shol69.static.otenet.gr ([83.235.170.67] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.87 #1 (Red Hat Linux)) id 1dEuoD-00030y-1q; Sun, 28 May 2017 09:48:25 +0000 From: Christoph Hellwig To: viro@zeniv.linux.org.uk Cc: linux-fsdevel@vger.kernel.org Subject: [PATCH 3/3] fs: mark vfs_readv and vfs_writev static Date: Sun, 28 May 2017 12:48:07 +0300 Message-Id: <20170528094807.26801-4-hch@lst.de> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170528094807.26801-1-hch@lst.de> References: <20170528094807.26801-1-hch@lst.de> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Users other than the syscalls should be using vfs_iter_read/write. Signed-off-by: Christoph Hellwig --- fs/read_write.c | 6 ++---- include/linux/fs.h | 4 ---- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/fs/read_write.c b/fs/read_write.c index 3d76e5bff62d..4fde69b05245 100644 --- a/fs/read_write.c +++ b/fs/read_write.c @@ -950,7 +950,7 @@ ssize_t vfs_iter_write(struct file *file, struct iov_iter *iter, loff_t *ppos, } EXPORT_SYMBOL(vfs_iter_write); -ssize_t vfs_readv(struct file *file, const struct iovec __user *vec, +static ssize_t vfs_readv(struct file *file, const struct iovec __user *vec, unsigned long vlen, loff_t *pos, int flags) { struct iovec iovstack[UIO_FASTIOV]; @@ -966,9 +966,8 @@ ssize_t vfs_readv(struct file *file, const struct iovec __user *vec, return ret; } -EXPORT_SYMBOL(vfs_readv); -ssize_t vfs_writev(struct file *file, const struct iovec __user *vec, +static ssize_t vfs_writev(struct file *file, const struct iovec __user *vec, unsigned long vlen, loff_t *pos, int flags) { struct iovec iovstack[UIO_FASTIOV]; @@ -983,7 +982,6 @@ ssize_t vfs_writev(struct file *file, const struct iovec __user *vec, } return ret; } -EXPORT_SYMBOL(vfs_writev); static ssize_t do_readv(unsigned long fd, const struct iovec __user *vec, unsigned long vlen, int flags) diff --git a/include/linux/fs.h b/include/linux/fs.h index 17955f196ad5..ac148c5909c9 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -1754,10 +1754,6 @@ extern ssize_t __vfs_read(struct file *, char __user *, size_t, loff_t *); extern ssize_t __vfs_write(struct file *, const char __user *, size_t, loff_t *); extern ssize_t vfs_read(struct file *, char __user *, size_t, loff_t *); extern ssize_t vfs_write(struct file *, const char __user *, size_t, loff_t *); -extern ssize_t vfs_readv(struct file *, const struct iovec __user *, - unsigned long, loff_t *, int); -extern ssize_t vfs_writev(struct file *, const struct iovec __user *, - unsigned long, loff_t *, int); extern ssize_t vfs_copy_file_range(struct file *, loff_t , struct file *, loff_t, size_t, unsigned int); extern int vfs_clone_file_prep_inodes(struct inode *inode_in, loff_t pos_in,