From patchwork Sat Jun 10 16:07:38 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Al Viro X-Patchwork-Id: 9779863 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A34E0601EA for ; Sat, 10 Jun 2017 16:08:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8E21628616 for ; Sat, 10 Jun 2017 16:08:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8121B28655; Sat, 10 Jun 2017 16:08:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1D2A628616 for ; Sat, 10 Jun 2017 16:08:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752011AbdFJQHo (ORCPT ); Sat, 10 Jun 2017 12:07:44 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:43986 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751943AbdFJQHn (ORCPT ); Sat, 10 Jun 2017 12:07:43 -0400 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.87 #1 (Red Hat Linux)) id 1dJivK-0006vh-Oc; Sat, 10 Jun 2017 16:07:38 +0000 Date: Sat, 10 Jun 2017 17:07:38 +0100 From: Al Viro To: Richard Narron Cc: Linus Torvalds , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [git pull] first batch of ufs fixes Message-ID: <20170610160738.GE6365@ZenIV.linux.org.uk> References: <20170609213830.GB6365@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Sat, Jun 10, 2017 at 06:03:24AM -0700, Richard Narron wrote: > 2) After creating a new filesystem on FreeBSD, then on Linux copying a > larger than 2GB file and creating a directory, the fsck back on FreeBSD > looks ok. > > But after going back to Linux and removing the large file and removing the > directory, the fsck on FreeBSD looks not so good: What happens is ufs_evict_inode() buggering off without syncing the inode in case of final removal. Incremental on top of that branch is Committed and pushed out... diff --git a/fs/ufs/inode.c b/fs/ufs/inode.c index 34f11cf0900a..da553ffec85b 100644 --- a/fs/ufs/inode.c +++ b/fs/ufs/inode.c @@ -848,6 +848,7 @@ void ufs_evict_inode(struct inode * inode) (S_ISREG(inode->i_mode) || S_ISDIR(inode->i_mode) || S_ISLNK(inode->i_mode))) ufs_truncate_blocks(inode); + ufs_update_inode(inode, inode_needs_sync(inode)); } invalidate_inode_buffers(inode);