From patchwork Thu Jul 6 18:27:25 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Potapenko X-Patchwork-Id: 9828713 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A2775604D9 for ; Thu, 6 Jul 2017 18:27:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 98DEE286C1 for ; Thu, 6 Jul 2017 18:27:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8D851286CC; Thu, 6 Jul 2017 18:27:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3563C286C6 for ; Thu, 6 Jul 2017 18:27:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752459AbdGFS1m (ORCPT ); Thu, 6 Jul 2017 14:27:42 -0400 Received: from mail-wr0-f171.google.com ([209.85.128.171]:35550 "EHLO mail-wr0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752328AbdGFS1k (ORCPT ); Thu, 6 Jul 2017 14:27:40 -0400 Received: by mail-wr0-f171.google.com with SMTP id k67so14135694wrc.2 for ; Thu, 06 Jul 2017 11:27:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=bpbpBRNLw3fcG6gRqCSx0vbS1C5G8WP+YvbGBXQ2hZg=; b=Huv3/vbXqUwMCyPpDlKmtmd2hm9a81bXtSJx6s6fLoy8f5IRLmVqDikkycmq9wZuIb 3FJLMvPpaZigJq9I94DzOjEoVY/XzpO/bQrS/pW1J8iSCuZPGTO1nmb6Y4YDf17v9Gpj NFbGL6yFow7K8ZtDl926QAMPOT0+JQzYnZEFGrOYljBwNkXZlP2Qs1QpRwWlr9m9rk+0 NS20uQVS8zDLXVrkBnq4g/xgDqMBqC1KhiGNy7+yd6rsiJazxeIPvsLyx6+msk/mYF0d YGhQtZ5uo1c/RQ5cBSWQiXCYXLo+9Sut17K3V+iokV6zuo4nWqA2SNypPL3XkcDz62lC pycw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=bpbpBRNLw3fcG6gRqCSx0vbS1C5G8WP+YvbGBXQ2hZg=; b=qQAgXg9axhcYjKqxYjwgn0qQue0xPHjyUnFHkRJW0jtXSd2EkAi+l+LC/WWGNLsJxN bvRtvFIDleOTHDh8qftax4+QC6RCy8GqFvog0kQFh7chXm/9Yp/tW6j1IzwB8KO/p95Z ujGc4evMh852DnH/pu2Aqa9LR4Sqps2Cild6MrPMB7cXOrkoHqErncCHjJxHd4BIUEtt DoyVeOhKhJmfP/T27OvBwaKvWsgphCDzLY8nn+OIQpRBYkEEeiSBwxbKbI/W+ZUGlIzU vEE/r5bZF/UjD/z6MHZeC0dujU2a6DPJAnfT6Zj+MK99sdJVR/UWrLdZQtgjTcmTvH2q pg0A== X-Gm-Message-State: AIVw113Wr6+fJILP77Mra0v3Ul3OeaTGnTSUNZ/hZuf5yjjc/8pe+mou VgRfDLyRZufjAWOC X-Received: by 10.28.220.133 with SMTP id t127mr384037wmg.29.1499365648252; Thu, 06 Jul 2017 11:27:28 -0700 (PDT) Received: from glider0.muc.corp.google.com ([100.105.28.21]) by smtp.gmail.com with ESMTPSA id j190sm1083857wmd.22.2017.07.06.11.27.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 06 Jul 2017 11:27:27 -0700 (PDT) From: Alexander Potapenko To: dvyukov@google.com, kcc@google.com, viro@zeniv.linux.org.uk, ebiggers@google.com, tytso@mit.edu Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: [PATCH] mbcache: initialize entry->e_referenced in mb_cache_entry_create() Date: Thu, 6 Jul 2017 20:27:25 +0200 Message-Id: <20170706182725.39194-1-glider@google.com> X-Mailer: git-send-email 2.13.2.725.g09c95d1e9-goog Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP KMSAN reported use of uninitialized |entry->e_referenced| in a condition in mb_cache_shrink(): Reviewed-by: Eric Biggers ================================================================== BUG: KMSAN: use of uninitialized memory in mb_cache_shrink+0x3b4/0xc50 fs/mbcache.c:287 CPU: 2 PID: 816 Comm: kswapd1 Not tainted 4.11.0-rc5+ #2877 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:16 [inline] dump_stack+0x172/0x1c0 lib/dump_stack.c:52 kmsan_report+0x12a/0x180 mm/kmsan/kmsan.c:927 __msan_warning_32+0x61/0xb0 mm/kmsan/kmsan_instr.c:469 mb_cache_shrink+0x3b4/0xc50 fs/mbcache.c:287 mb_cache_scan+0x67/0x80 fs/mbcache.c:321 do_shrink_slab mm/vmscan.c:397 [inline] shrink_slab+0xc3d/0x12d0 mm/vmscan.c:500 shrink_node+0x208f/0x2fd0 mm/vmscan.c:2603 kswapd_shrink_node mm/vmscan.c:3172 [inline] balance_pgdat mm/vmscan.c:3289 [inline] kswapd+0x160f/0x2850 mm/vmscan.c:3478 kthread+0x46c/0x5f0 kernel/kthread.c:230 ret_from_fork+0x29/0x40 arch/x86/entry/entry_64.S:430 chained origin: save_stack_trace+0x37/0x40 arch/x86/kernel/stacktrace.c:59 kmsan_save_stack_with_flags mm/kmsan/kmsan.c:302 [inline] kmsan_save_stack mm/kmsan/kmsan.c:317 [inline] kmsan_internal_chain_origin+0x12a/0x1f0 mm/kmsan/kmsan.c:547 __msan_store_shadow_origin_1+0xac/0x110 mm/kmsan/kmsan_instr.c:257 mb_cache_entry_create+0x3b3/0xc60 fs/mbcache.c:95 ext4_xattr_cache_insert fs/ext4/xattr.c:1647 [inline] ext4_xattr_block_set+0x4c82/0x5530 fs/ext4/xattr.c:1022 ext4_xattr_set_handle+0x1332/0x20a0 fs/ext4/xattr.c:1252 ext4_xattr_set+0x4d2/0x680 fs/ext4/xattr.c:1306 ext4_xattr_trusted_set+0x8d/0xa0 fs/ext4/xattr_trusted.c:36 __vfs_setxattr+0x703/0x790 fs/xattr.c:149 __vfs_setxattr_noperm+0x27a/0x6f0 fs/xattr.c:180 vfs_setxattr fs/xattr.c:223 [inline] setxattr+0x6ae/0x790 fs/xattr.c:449 path_setxattr+0x1eb/0x380 fs/xattr.c:468 SYSC_lsetxattr+0x8d/0xb0 fs/xattr.c:490 SyS_lsetxattr+0x77/0xa0 fs/xattr.c:486 entry_SYSCALL_64_fastpath+0x13/0x94 origin: save_stack_trace+0x37/0x40 arch/x86/kernel/stacktrace.c:59 kmsan_save_stack_with_flags mm/kmsan/kmsan.c:302 [inline] kmsan_internal_poison_shadow+0xb1/0x1a0 mm/kmsan/kmsan.c:198 kmsan_kmalloc+0x7f/0xe0 mm/kmsan/kmsan.c:337 kmem_cache_alloc+0x1c2/0x1e0 mm/slub.c:2766 mb_cache_entry_create+0x283/0xc60 fs/mbcache.c:86 ext4_xattr_cache_insert fs/ext4/xattr.c:1647 [inline] ext4_xattr_block_set+0x4c82/0x5530 fs/ext4/xattr.c:1022 ext4_xattr_set_handle+0x1332/0x20a0 fs/ext4/xattr.c:1252 ext4_xattr_set+0x4d2/0x680 fs/ext4/xattr.c:1306 ext4_xattr_trusted_set+0x8d/0xa0 fs/ext4/xattr_trusted.c:36 __vfs_setxattr+0x703/0x790 fs/xattr.c:149 __vfs_setxattr_noperm+0x27a/0x6f0 fs/xattr.c:180 vfs_setxattr fs/xattr.c:223 [inline] setxattr+0x6ae/0x790 fs/xattr.c:449 path_setxattr+0x1eb/0x380 fs/xattr.c:468 SYSC_lsetxattr+0x8d/0xb0 fs/xattr.c:490 SyS_lsetxattr+0x77/0xa0 fs/xattr.c:486 entry_SYSCALL_64_fastpath+0x13/0x94 ================================================================== Signed-off-by: Alexander Potapenko --- fs/mbcache.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/mbcache.c b/fs/mbcache.c index b19be429d655..fdfe8933ac6b 100644 --- a/fs/mbcache.c +++ b/fs/mbcache.c @@ -93,6 +93,7 @@ int mb_cache_entry_create(struct mb_cache *cache, gfp_t mask, u32 key, entry->e_key = key; entry->e_block = block; entry->e_reusable = reusable; + entry->e_referenced = 0; head = mb_cache_entry_head(cache, key); hlist_bl_lock(head); hlist_bl_for_each_entry(dup, dup_node, head, e_hash_list) {