From patchwork Tue Aug 29 22:37:15 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ross Zwisler X-Patchwork-Id: 9928409 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 655FB602B9 for ; Tue, 29 Aug 2017 22:38:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 19E3428A86 for ; Tue, 29 Aug 2017 22:38:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 060BD28A94; Tue, 29 Aug 2017 22:38:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8AF1628A8B for ; Tue, 29 Aug 2017 22:38:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751425AbdH2WhY (ORCPT ); Tue, 29 Aug 2017 18:37:24 -0400 Received: from mga11.intel.com ([192.55.52.93]:34894 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751272AbdH2WhW (ORCPT ); Tue, 29 Aug 2017 18:37:22 -0400 Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Aug 2017 15:37:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,446,1498546800"; d="scan'208";a="143447416" Received: from theros.lm.intel.com ([10.232.112.77]) by orsmga005.jf.intel.com with ESMTP; 29 Aug 2017 15:37:21 -0700 From: Ross Zwisler To: fstests@vger.kernel.org, Eryu Guan Cc: Ross Zwisler , linux-ext4@vger.kernel.org, linux-nvdimm@lists.01.org, linux-fsdevel@vger.kernel.org, Randy Dodgen , Christoph Hellwig , Theodore Ts'o Subject: [fstests PATCH] generic: add test for executables on read-only DAX mounts Date: Tue, 29 Aug 2017 16:37:15 -0600 Message-Id: <20170829223715.26507-1-ross.zwisler@linux.intel.com> X-Mailer: git-send-email 2.9.5 In-Reply-To: <20170829213721.GA27686@linux.intel.com> References: <20170829213721.GA27686@linux.intel.com> Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This adds a regression test for the following kernel patch: commit 42d4a99b09cb ("ext4: fix fault handling when mounted with -o dax,ro") The above patch fixes an issue with ext4 where executables cannot be run on read-only filesystems mounted with the DAX option. This issue does not appear to be present in ext2 or XFS, as they both pass the test. I've also confirmed outside of the test that they are both indeed able to execute binaries on read-only DAX mounts. Thanks to Randy Dodgen for the bug report and reproduction steps. Signed-off-by: Ross Zwisler Cc: Randy Dodgen Cc: Christoph Hellwig Cc: Theodore Ts'o --- Sorry if we collided, Randy, but I was 90% done with the test by the time I saw your mail. :) --- tests/generic/451 | 87 +++++++++++++++++++++++++++++++++++++++++++++++++++ tests/generic/451.out | 2 ++ tests/generic/group | 1 + 3 files changed, 90 insertions(+) create mode 100755 tests/generic/451 create mode 100644 tests/generic/451.out diff --git a/tests/generic/451 b/tests/generic/451 new file mode 100755 index 0000000..54dda8c --- /dev/null +++ b/tests/generic/451 @@ -0,0 +1,87 @@ +#! /bin/bash +# FS QA Test 451 +# +# This is a regression test for kernel patch: +# commit 42d4a99b09cb ("ext4: fix fault handling when mounted with -o dax,ro") +# created by Ross Zwisler +# +#----------------------------------------------------------------------- +# Copyright (c) 2017 Intel Corporation. All Rights Reserved. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- +# + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# remove previous $seqres.full before test +rm -f $seqres.full + +# Modify as appropriate. +_supported_fs generic +_supported_os Linux +_require_scratch + +# real QA test starts here +# format and mount +_scratch_mkfs > $seqres.full 2>&1 +_scratch_mount >> $seqres.full 2>&1 + +LS=$(which ls --skip-alias --skip-functions) 2>/dev/null +if [ $? -ne 0 ]; then + status=$? + echo "Couldn't find 'ls'!?" + exit +fi + +cp $LS $SCRATCH_MNT +SCRATCH_LS=$SCRATCH_MNT/ls + +$SCRATCH_LS >/dev/null 2>&1 +if [ $? -ne 0 ]; then + status=$? + echo "$SCRATCH_LS not working before remount" + exit +fi + +_scratch_remount ro + +$SCRATCH_LS >/dev/null 2>&1 +if [ $? -ne 0 ]; then + status=$? + echo "$SCRATCH_LS not working after remount" + exit +fi + +# success, all done +echo "Silence is golden" +status=0 +exit diff --git a/tests/generic/451.out b/tests/generic/451.out new file mode 100644 index 0000000..db92441 --- /dev/null +++ b/tests/generic/451.out @@ -0,0 +1,2 @@ +QA output created by 451 +Silence is golden diff --git a/tests/generic/group b/tests/generic/group index 044ec3f..45f5789 100644 --- a/tests/generic/group +++ b/tests/generic/group @@ -453,3 +453,4 @@ 448 auto quick rw 449 auto quick acl enospc 450 auto quick rw +451 auto quick