From patchwork Fri Sep 1 15:39:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 9934635 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0BC776016C for ; Fri, 1 Sep 2017 15:45:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0015223B23 for ; Fri, 1 Sep 2017 15:45:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E940023B32; Fri, 1 Sep 2017 15:45:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 69BB923B23 for ; Fri, 1 Sep 2017 15:45:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752548AbdIAPo6 (ORCPT ); Fri, 1 Sep 2017 11:44:58 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:49429 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752406AbdIAPkK (ORCPT ); Fri, 1 Sep 2017 11:40:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=References:In-Reply-To:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=dIa6nnRzzd2nUOT2FOJFFHpOjgILfj1VSRlIKnJvipA=; b=cGr9dpvbvGyvSj+cXT/izrjNL l+ykTkiw/Mq9VFTA1kiGRT4G2Ui2m+lU5saMZ8xTPejwf5LcG7saoTGjOk8nTL/Q2nO/HizRWFCTu Oej+Rai9ueVIjNIYcjpEY9Opn56zFs7YWj0MhlwAGfVPc753BgwanHD38CF/K9Kt110NloV7TzBFp S+Kebvqfw6/2h7OMxZ+pgcD48/2UsPBNfcef00K2XtflZACnZdYrfTYnBk8X0WLOySPBeZWn9R9Dq AEWpK48+R0dI/ybPpEN11eYu2J/7Hvp4Nq7lRf2JIJ4znEqtg2n381yC6+7btib9zD3G9lGeTYQ3S 1U+lgn39w==; Received: from 80-109-164-210.cable.dynamic.surfer.at ([80.109.164.210] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.87 #1 (Red Hat Linux)) id 1dno3F-00041o-1j; Fri, 01 Sep 2017 15:40:09 +0000 From: Christoph Hellwig To: viro@zeniv.linux.org.uk Cc: arve@android.com, riandrews@android.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 12/17] mconsole: switch to kernel_read Date: Fri, 1 Sep 2017 17:39:20 +0200 Message-Id: <20170901153925.30578-13-hch@lst.de> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170901153925.30578-1-hch@lst.de> References: <20170901153925.30578-1-hch@lst.de> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Instead of playing with address limits. Signed-off-by: Christoph Hellwig --- arch/um/drivers/mconsole_kern.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/arch/um/drivers/mconsole_kern.c b/arch/um/drivers/mconsole_kern.c index af326fb6510d..c4d162a94be9 100644 --- a/arch/um/drivers/mconsole_kern.c +++ b/arch/um/drivers/mconsole_kern.c @@ -148,12 +148,7 @@ void mconsole_proc(struct mc_request *req) } do { - loff_t pos = file->f_pos; - mm_segment_t old_fs = get_fs(); - set_fs(KERNEL_DS); - len = vfs_read(file, buf, PAGE_SIZE - 1, &pos); - set_fs(old_fs); - file->f_pos = pos; + len = kernel_read(file, buf, PAGE_SIZE - 1, &file->f_pos); if (len < 0) { mconsole_reply(req, "Read of file failed", 1, 0); goto out_free;