From patchwork Mon Sep 4 07:49:31 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Zijlstra X-Patchwork-Id: 9936769 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 01D066035F for ; Mon, 4 Sep 2017 07:49:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E58FE28763 for ; Mon, 4 Sep 2017 07:49:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D823428765; Mon, 4 Sep 2017 07:49:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8E01F28763 for ; Mon, 4 Sep 2017 07:49:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753329AbdIDHti (ORCPT ); Mon, 4 Sep 2017 03:49:38 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:48421 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753309AbdIDHtg (ORCPT ); Mon, 4 Sep 2017 03:49:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=2DqlEEq6PqIFcipDd7i8m1x8jM7FeHLyvNmz6o/P0ho=; b=ida5DyQ2C7q6dvOCnxYsf7dKw 859zdz0VD5YVOebxodhLdrJEyZiJt7QUQJf5jDEjlXPUDmryPspGZ8uaUpr9qMIA2wsqtNOrRiZyu k38/sySNGM3nXDhYGM8fmy4dDulKxkiYBBkasX5Qns1oorxaXzDQueaXoKysFp1WYIOq0Y8/hZoiy ohCBJYaql52fwYoPqmwBH7DgXBWloUOxvc1HAUOmi3jNUCIXrvgZdpo20YRPVu/cMq6QaaQtnKNrT 0etQBPeXqn5MMvER11yN+zeIudu5NEcsZkF8X/RlotTUwM1djzUNpHQmq6wukCidNYntk5g6TykUo Sk1hSJucw==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.87 #1 (Red Hat Linux)) id 1dom8T-0006ym-4h; Mon, 04 Sep 2017 07:49:33 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 6FFAF202A064C; Mon, 4 Sep 2017 09:49:31 +0200 (CEST) Date: Mon, 4 Sep 2017 09:49:31 +0200 From: Peter Zijlstra To: Ethan Zhao Cc: mingo@redhat.com, mcgrof@kernel.org, keescook@chromium.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, james.puthukattukaran@oracle.com, ethan.kernel@gmail.com Subject: Re: [PATCH v2] sched: check user input value of sysctl_sched_time_avg Message-ID: <20170904074931.oyhe4gz5jnhfmnw6@hirez.programming.kicks-ass.net> References: <1504335452-31806-1-git-send-email-ethan.zhao@oracle.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1504335452-31806-1-git-send-email-ethan.zhao@oracle.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Sat, Sep 02, 2017 at 02:57:32PM +0800, Ethan Zhao wrote: > diff --git a/kernel/sysctl.c b/kernel/sysctl.c > index 6648fbb..609bed2 100644 > --- a/kernel/sysctl.c > +++ b/kernel/sysctl.c > @@ -367,7 +367,7 @@ static int sysrq_sysctl_handler(struct ctl_table *table, int write, > .data = &sysctl_sched_time_avg, > .maxlen = sizeof(unsigned int), > .mode = 0644, > - .proc_handler = proc_dointvec, > + .proc_handler = sched_time_avg_handler, *sigh*, what's wrong with the below? Too easy? diff --git a/kernel/sysctl.c b/kernel/sysctl.c index 6648fbbb8157..bbbc6a17c15e 100644 --- a/kernel/sysctl.c +++ b/kernel/sysctl.c @@ -367,7 +367,8 @@ static struct ctl_table kern_table[] = { .data = &sysctl_sched_time_avg, .maxlen = sizeof(unsigned int), .mode = 0644, - .proc_handler = proc_dointvec, + .proc_handler = proc_dointvec_min_max, + .extra1 = &one, }, #ifdef CONFIG_SCHEDSTATS {