writeback: make try_to_writeback_inodes_sb_nr() static

Commit Message

Rakesh Pandit Oct. 9, 2017, 7:36 a.m. UTC

Since commit 925a6efb8ff0c ("Btrfs: stop using
try_to_writeback_inodes_sb_nr to flush delalloc") this function hasn't
been used outside so stop exporting it.

Signed-off-by: Rakesh Pandit <[e-mail]>
---
 fs/fs-writeback.c         | 6 +++---
 include/linux/writeback.h | 2 --
 2 files changed, 3 insertions(+), 5 deletions(-)

Comments

Christoph Hellwig Oct. 9, 2017, 9:34 a.m. UTC | #1

On Mon, Oct 09, 2017 at 10:36:30AM +0300, Rakesh Pandit wrote:
> Since commit 925a6efb8ff0c ("Btrfs: stop using
> try_to_writeback_inodes_sb_nr to flush delalloc") this function hasn't
> been used outside so stop exporting it.

It also only has a single caller left, so we might want to just inline
it it into that.

Patch

diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
index 9e24d60..29dd08a 100644
--- a/fs/fs-writeback.c
+++ b/fs/fs-writeback.c
@@ -2384,8 +2384,9 @@  EXPORT_SYMBOL(writeback_inodes_sb);
  * Invoke writeback_inodes_sb_nr if no writeback is currently underway.
  * Returns 1 if writeback was started, 0 if not.
  */
-bool try_to_writeback_inodes_sb_nr(struct super_block *sb, unsigned long nr,
-				   enum wb_reason reason)
+static bool try_to_writeback_inodes_sb_nr(struct super_block *sb,
+					  unsigned long nr,
+					  enum wb_reason reason)
 {
 	if (!down_read_trylock(&sb->s_umount))
 		return false;
@@ -2394,7 +2395,6 @@  bool try_to_writeback_inodes_sb_nr(struct super_block *sb, unsigned long nr,
 	up_read(&sb->s_umount);
 	return true;
 }
-EXPORT_SYMBOL(try_to_writeback_inodes_sb_nr);
 
 /**
  * try_to_writeback_inodes_sb - try to start writeback if none underway
diff --git a/include/linux/writeback.h b/include/linux/writeback.h
index dd1d2c2..0bd8534 100644
--- a/include/linux/writeback.h
+++ b/include/linux/writeback.h
@@ -164,8 +164,6 @@  void writeback_inodes_sb(struct super_block *, enum wb_reason reason);
 void writeback_inodes_sb_nr(struct super_block *, unsigned long nr,
 							enum wb_reason reason);
 bool try_to_writeback_inodes_sb(struct super_block *, enum wb_reason reason);
-bool try_to_writeback_inodes_sb_nr(struct super_block *, unsigned long nr,
-				   enum wb_reason reason);
 void sync_inodes_sb(struct super_block *);
 void wakeup_flusher_threads(enum wb_reason reason);
 void wakeup_flusher_threads_bdi(struct backing_dev_info *bdi,