| Message ID | 20180117045832.15103-1-realwakka@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed 17-01-18 04:58:32, Sidong Yang wrote: > Fix error reported by checkpatch.pl about space prohibited before > that close parenthesis ')'. > > Signed-off-by: Sidong Yang <realwakka@gmail.com> Sorry, but this is just making checkpatch happy without looking too much at the result. The indentation of FANOTIFY_INIT_ALL_EVENT_F_BITS definition is such that braces are aligned with | operators. And, although it is somewhat non-standard, it looks nice and better to me than the alternative suggested by checkpatch. So won't apply this patch. Honza > --- > fs/notify/fanotify/fanotify_user.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/notify/fanotify/fanotify_user.c b/fs/notify/fanotify/fanotify_user.c > index d0d4bc4c4b70..291fe6800bce 100644 > --- a/fs/notify/fanotify/fanotify_user.c > +++ b/fs/notify/fanotify/fanotify_user.c > @@ -38,7 +38,7 @@ > #define FANOTIFY_INIT_ALL_EVENT_F_BITS ( \ > O_ACCMODE | O_APPEND | O_NONBLOCK | \ > __O_SYNC | O_DSYNC | O_CLOEXEC | \ > - O_LARGEFILE | O_NOATIME ) > + O_LARGEFILE | O_NOATIME) > > extern const struct fsnotify_ops fanotify_fsnotify_ops; > > -- > 2.11.0 >
diff --git a/fs/notify/fanotify/fanotify_user.c b/fs/notify/fanotify/fanotify_user.c index d0d4bc4c4b70..291fe6800bce 100644 --- a/fs/notify/fanotify/fanotify_user.c +++ b/fs/notify/fanotify/fanotify_user.c @@ -38,7 +38,7 @@ #define FANOTIFY_INIT_ALL_EVENT_F_BITS ( \ O_ACCMODE | O_APPEND | O_NONBLOCK | \ __O_SYNC | O_DSYNC | O_CLOEXEC | \ - O_LARGEFILE | O_NOATIME ) + O_LARGEFILE | O_NOATIME) extern const struct fsnotify_ops fanotify_fsnotify_ops;
Fix error reported by checkpatch.pl about space prohibited before that close parenthesis ')'. Signed-off-by: Sidong Yang <realwakka@gmail.com> --- fs/notify/fanotify/fanotify_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)