From patchwork Mon Jan 29 08:00:41 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Vagin X-Patchwork-Id: 10189383 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id F036A60388 for ; Mon, 29 Jan 2018 08:01:00 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E3655285DC for ; Mon, 29 Jan 2018 08:01:00 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D81222863E; Mon, 29 Jan 2018 08:01:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2E1B128615 for ; Mon, 29 Jan 2018 08:01:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751411AbeA2IA6 (ORCPT ); Mon, 29 Jan 2018 03:00:58 -0500 Received: from mail-pg0-f65.google.com ([74.125.83.65]:39868 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751355AbeA2IAy (ORCPT ); Mon, 29 Jan 2018 03:00:54 -0500 Received: by mail-pg0-f65.google.com with SMTP id w17so3829457pgv.6 for ; Mon, 29 Jan 2018 00:00:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=NiiqLcXEzPio57AA98xPP/TK3UmNrmPFDFKDvKa7U8o=; b=NW0kKxZSxs3aIQSPlh72k82CBTqc6okPjEcWCTQLovTpXhaesI8oWfMrKS9vXns/ua mpJn7E2TcNAkqTZ68jUM931tEebttp6U69Rsubc1DtoWNKJ2rrrOpDi/1EYNz+ctzRTO gn2sh572/tP/+3twgUFTPoxa0CUjv0r2bXHO1BQtAXddooQacSLtntfCJAPHlWNcvj3T 0BVxLELUIygUxYzqjJP0UfwoPx6wm6KpJMmQBpJiImGoigoBCBsN8iyufoDOJzilZzXo 4kr7HlvUkBj3d/lBbaI3shFR9LkfHTqHaDIRkm5zc09rDpQJdBavvs2c08s1s3REOpp6 lsAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=NiiqLcXEzPio57AA98xPP/TK3UmNrmPFDFKDvKa7U8o=; b=HLEKcgxZuhesmZNSX/VL8KSthu04Hi3skzm8viPZXxrmddzK5jEf9PvkDH39zVhwy4 r91BKlwHqIHzZfK7OpQ/QtwnssfcG+olslzLhQWBVvuxgCNs8f6/DP7FAoscC7ClJjeq AELtLIq/9xUOKp/7EWPmRp7y0mn5SCg2JOcoV/gNRGE3sw3waFHcRBGs7ai6+zy/0bZp 6ctDiKKdtLSdf3pYDTtBt+t78W8LhCiq0ffw5zSKyQWSFfdQyVGxWwzpJNnnY58Z3HnE 29hp2yLTtzXKqJ9Nf0ernC9nd/7n7AQ3sl97+DUS/gUFvzf9au91k2F4OhJpUgaNwHBK Y9yQ== X-Gm-Message-State: AKwxyteZypXJOXZjgTuecvJM8FwbmVQCW+YCcM63qEywZmfhJV24BJjW a9xDjOiK6xdko+Cjvzdzq1pssOjF X-Google-Smtp-Source: AH8x225jGk6M93y4VSZdd03TuvTQmP+1bXwwphpU5nDKwgPI0avtYImox87JeiEin0upzUS2/TUQxg== X-Received: by 2002:a17:902:8a91:: with SMTP id p17-v6mr21197025plo.375.1517212853039; Mon, 29 Jan 2018 00:00:53 -0800 (PST) Received: from localhost.localdomain (c-73-140-212-29.hsd1.wa.comcast.net. [73.140.212.29]) by smtp.gmail.com with ESMTPSA id 191sm30112462pfv.127.2018.01.29.00.00.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 29 Jan 2018 00:00:52 -0800 (PST) From: Andrei Vagin To: linux-fsdevel@vger.kernel.org, Andrew Morton Cc: Alexey Dobriyan , Andrei Vagin , KAMEZAWA Hiroyuki Subject: [PATCH 2/4] proc: replace seq_printf on seq_putc to speed up /proc/pid/smaps Date: Mon, 29 Jan 2018 00:00:41 -0800 Message-Id: <20180129080043.14191-2-avagin@openvz.org> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20180129080043.14191-1-avagin@openvz.org> References: <20180129080043.14191-1-avagin@openvz.org> Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP seq_putc() works much faster than seq_printf() $ time python test_smaps.py == Before patch == real 0m3.828s user 0m0.413s sys 0m3.408s == After patch == real 0m3.405s user 0m0.401s sys 0m3.003s == Before patch == - 75.51% 4.62% python [kernel.kallsyms] [k] show_smap.isra.33 - 70.88% show_smap.isra.33 + 24.82% seq_put_decimal_ull_aligned + 19.78% __walk_page_range + 12.74% seq_printf + 11.08% show_map_vma.isra.23 + 1.68% seq_puts == After patch == - 69.16% 5.70% python [kernel.kallsyms] [k] show_smap.isra.33 - 63.46% show_smap.isra.33 + 25.98% seq_put_decimal_ull_aligned + 20.90% __walk_page_range + 12.60% show_map_vma.isra.23 1.56% seq_putc + 1.55% seq_puts Cc: Alexey Dobriyan Cc: KAMEZAWA Hiroyuki Signed-off-by: Andrei Vagin --- fs/proc/task_mmu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c index cc0aaf3a7315..d7a429132a1f 100644 --- a/fs/proc/task_mmu.c +++ b/fs/proc/task_mmu.c @@ -685,8 +685,9 @@ static void show_smap_vma_flags(struct seq_file *m, struct vm_area_struct *vma) if (!mnemonics[i][0]) continue; if (vma->vm_flags & (1UL << i)) { - seq_printf(m, "%c%c ", - mnemonics[i][0], mnemonics[i][1]); + seq_putc(m, mnemonics[i][0]); + seq_putc(m, mnemonics[i][1]); + seq_putc(m, ' '); } } seq_putc(m, '\n');