| Message ID | 20180412150826.20988-8-mszeredi@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Apr 12, 2018 at 05:07:58PM +0200, Miklos Szeredi wrote: > Copy i_size of the underlying inode to the overlay inode in ovl_copyattr(). > > This is in preparation for stacking I/O operations on overlay files. > > This patch shouldn't have any observable effect. > > Signed-off-by: Miklos Szeredi <mszeredi@redhat.com> > --- > fs/overlayfs/overlayfs.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/overlayfs/overlayfs.h b/fs/overlayfs/overlayfs.h > index 265cb288417a..10f5f3bf9d96 100644 > --- a/fs/overlayfs/overlayfs.h > +++ b/fs/overlayfs/overlayfs.h > @@ -9,6 +9,7 @@ > > #include <linux/kernel.h> > #include <linux/uuid.h> > +#include <linux/fs.h> > #include "ovl_entry.h" > > enum ovl_path_type { > @@ -355,6 +356,7 @@ static inline void ovl_copyattr(struct inode *from, struct inode *to) > to->i_atime = from->i_atime; > to->i_mtime = from->i_mtime; > to->i_ctime = from->i_ctime; > + i_size_write(to, i_size_read(from)); > } With this change, is following comment in ovl_getattr() stale now. /* * We don't initialize inode->size, which just means that * inode_newsize_ok() will always check against MAX_LFS_FILESIZE and not * check for a swapfile (which this won't be anyway). */ Thanks Vivek
diff --git a/fs/overlayfs/overlayfs.h b/fs/overlayfs/overlayfs.h index 265cb288417a..10f5f3bf9d96 100644 --- a/fs/overlayfs/overlayfs.h +++ b/fs/overlayfs/overlayfs.h @@ -9,6 +9,7 @@ #include <linux/kernel.h> #include <linux/uuid.h> +#include <linux/fs.h> #include "ovl_entry.h" enum ovl_path_type { @@ -355,6 +356,7 @@ static inline void ovl_copyattr(struct inode *from, struct inode *to) to->i_atime = from->i_atime; to->i_mtime = from->i_mtime; to->i_ctime = from->i_ctime; + i_size_write(to, i_size_read(from)); } static inline void ovl_copyflags(struct inode *from, struct inode *to)
Copy i_size of the underlying inode to the overlay inode in ovl_copyattr(). This is in preparation for stacking I/O operations on overlay files. This patch shouldn't have any observable effect. Signed-off-by: Miklos Szeredi <mszeredi@redhat.com> --- fs/overlayfs/overlayfs.h | 2 ++ 1 file changed, 2 insertions(+)