From patchwork Tue May 29 14:43:25 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miklos Szeredi X-Patchwork-Id: 10435731 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 82F1C602BF for ; Tue, 29 May 2018 14:45:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 744F528414 for ; Tue, 29 May 2018 14:45:21 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 66FEB2863D; Tue, 29 May 2018 14:45:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1611F28414 for ; Tue, 29 May 2018 14:45:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936504AbeE2OpD (ORCPT ); Tue, 29 May 2018 10:45:03 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:38188 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935738AbeE2OoM (ORCPT ); Tue, 29 May 2018 10:44:12 -0400 Received: by mail-wm0-f68.google.com with SMTP id m129-v6so41262183wmb.3 for ; Tue, 29 May 2018 07:44:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=V2OmmVFBuUSgQckE8B0XrGIAQg/4IsUcPqZSEaSvA5o=; b=STsYJ5MqQRXF+RCPl62YvjI7pzxdFRRBg9C7w5+h2sp8F271evQAQxjJ+J5FUF7ReF U9er+nUpbVUNblFmU4ynD6Dn2F4zKwO0WxVyfWEGArqOZYI67+5gGyQrYT+M4uAY2pIX f3VNSAdvEleh7b3/CyZr5mgIcS3punE/Snm+ylso+hn8Q7gd6TbIBrFz/nUU9yhQol/h g/6Zg4NMTur9nH1ePEMC5+aGDSJDVcU53t5VMf6hGY+F/Pms7lmpCRclackakfSq6hqC K5eg7NPFpaXp01fqNg6Hn5zVMA0tTaWhaCSjsUeGrJ+iCYxDXLeQCnm9wAWXw/P+kRJ9 OTuw== X-Gm-Message-State: ALKqPwfCHHS87NzGUO05rBi2i1jbfave9Zp4a8XlzSfzkSwhDkHVtKtB CH2b5hc+/7F7bD0OLGVb/G/7ww== X-Google-Smtp-Source: ADUXVKJNYZMTG2hoqbWv+uFvhjFKQPME7czahmzcod+S4qi1NQRuTnFcGGjf+epfukY/9vjLjrE4lQ== X-Received: by 2002:a1c:aac3:: with SMTP id t186-v6mr4528800wme.14.1527605051094; Tue, 29 May 2018 07:44:11 -0700 (PDT) Received: from veci.piliscsaba.redhat.com (catv-176-63-54-97.catv.broadband.hu. [176.63.54.97]) by smtp.gmail.com with ESMTPSA id t198-v6sm18834422wmt.23.2018.05.29.07.44.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 29 May 2018 07:44:10 -0700 (PDT) From: Miklos Szeredi To: linux-unionfs@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 25/39] vfs: don't open real Date: Tue, 29 May 2018 16:43:25 +0200 Message-Id: <20180529144339.16538-26-mszeredi@redhat.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180529144339.16538-1-mszeredi@redhat.com> References: <20180529144339.16538-1-mszeredi@redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Let overlayfs do its thing when opening a file. This enables stacking and fixes the corner case when a file is opened for read, modified through a writable open, and data is read from the read-only file. After this patch the read-only open will not return stale data even in this case. Signed-off-by: Miklos Szeredi --- fs/open.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/fs/open.c b/fs/open.c index 6e52fd6fea7c..244cd2ecfefd 100644 --- a/fs/open.c +++ b/fs/open.c @@ -897,13 +897,8 @@ EXPORT_SYMBOL(file_path); int vfs_open(const struct path *path, struct file *file, const struct cred *cred) { - struct dentry *dentry = d_real(path->dentry, NULL, file->f_flags, 0); - - if (IS_ERR(dentry)) - return PTR_ERR(dentry); - file->f_path = *path; - return do_dentry_open(file, d_backing_inode(dentry), NULL, cred); + return do_dentry_open(file, d_backing_inode(path->dentry), NULL, cred); } /**