From patchwork Tue Sep 18 13:34:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amir Goldstein X-Patchwork-Id: 10604333 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0E1D36CB for ; Tue, 18 Sep 2018 13:34:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F245F2ABA9 for ; Tue, 18 Sep 2018 13:34:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E4A3F2ABBC; Tue, 18 Sep 2018 13:34:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9D2E12ABA9 for ; Tue, 18 Sep 2018 13:34:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729791AbeIRTHZ (ORCPT ); Tue, 18 Sep 2018 15:07:25 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:39200 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728575AbeIRTHZ (ORCPT ); Tue, 18 Sep 2018 15:07:25 -0400 Received: by mail-wm1-f65.google.com with SMTP id q8-v6so2829272wmq.4; Tue, 18 Sep 2018 06:34:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=zTavsqr1OFg0MIRSjpyqKsc+XuAFMdysP0g3Gi0Xnkc=; b=ZXqPRlkGWjBUEORwAjN19vH1SHXrqDdWo91N29ju6Atqsj8yaTFI+kSqpBp8axMo25 IFj596z9FYlKM4HjHV+XBnTZ2IyJVCJS932NNOin+F0/2jwmzldBkfpdWFy1qgIWf54v x6Hl/WmacLJIca3xiA476HPMLHb++D4BRxdzhkEZ6pwdYN5daJKZJDRkajGcTqjYk66M oZHbbFNPPCE/VTo0bZ9DuRUA8KAER1otRgiakYiQV+IgYqWmveHVN9l9brSiOmTEte0a gWJJKPrJFve2SecpYbPoE+O1+PuTq34mwD6sgmI0+aHGlJATOXzEie+Z/O/iDDC6bSCo xx0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=zTavsqr1OFg0MIRSjpyqKsc+XuAFMdysP0g3Gi0Xnkc=; b=bOLEzBfcjWTZMmsaMDSLLR180gqDKHVAJHn+IFJFyA+WNOhRu6zF6wkFAudgvUPTbO BW4LnX+Ql6CoPP5TQg3dVPDWfGX1AbshvmQfhwiSvMAPqbl/efLE1QvzZLUlPyD1CHLG YTbj+C0GGhbJY9PJgCXaXhpMiz3B9PqFiLKjwoPuFzoujwJLQtI8omxpWqwY97pFpRKH lq5jVNqcLipPI8vSCyXPafHFUsD8Q161+w1YKAD7OmNQC52EoC6sG0eNjStFdcxDOx8x Cxp8Exrx9oSU5V/BB/fLVklE2qi9WlIjOvh7V8hYvatPbGMIjxkX3bUNzFomgX3wDsxD yP9Q== X-Gm-Message-State: APzg51AIRfDjhMH4Ey9BVXJf+55CiTGW+ot/G33sDI8uF0h+SfYRoHj+ 5D+Dw8h3Al46zVMmHWC8QYs= X-Google-Smtp-Source: ANB0VdZ3hqmPSEI2/Df3L5JPshnmAOvgIK8MNXzrQC/pBiva1U3bvRggRFp/MbAJzp4JBZF6RBAvAg== X-Received: by 2002:a1c:8dc6:: with SMTP id p189-v6mr16449776wmd.3.1537277686346; Tue, 18 Sep 2018 06:34:46 -0700 (PDT) Received: from localhost.localdomain ([141.226.14.107]) by smtp.gmail.com with ESMTPSA id h7-v6sm16905065wrs.3.2018.09.18.06.34.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 18 Sep 2018 06:34:45 -0700 (PDT) From: Amir Goldstein To: Miklos Szeredi Cc: Al Viro , linux-unionfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH 1/4] ovl: fix memory leak on unlink of indexed file Date: Tue, 18 Sep 2018 16:34:31 +0300 Message-Id: <20180918133434.27437-2-amir73il@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180918133434.27437-1-amir73il@gmail.com> References: <20180918133434.27437-1-amir73il@gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Fixes: caf70cb2ba5d ("ovl: cleanup orphan index entries") Cc: # v4.13 Signed-off-by: Amir Goldstein --- fs/overlayfs/util.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/overlayfs/util.c b/fs/overlayfs/util.c index 8cfb62cc8672..ace4fe4c39a9 100644 --- a/fs/overlayfs/util.c +++ b/fs/overlayfs/util.c @@ -683,7 +683,7 @@ static void ovl_cleanup_index(struct dentry *dentry) struct dentry *upperdentry = ovl_dentry_upper(dentry); struct dentry *index = NULL; struct inode *inode; - struct qstr name; + struct qstr name = { }; int err; err = ovl_get_index_name(lowerdentry, &name); @@ -726,6 +726,7 @@ static void ovl_cleanup_index(struct dentry *dentry) goto fail; out: + kfree(name.name); dput(index); return;