From patchwork Wed Nov 21 19:06:59 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Phillip Potter X-Patchwork-Id: 10693097 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4822213BF for ; Wed, 21 Nov 2018 19:07:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 31C232B68D for ; Wed, 21 Nov 2018 19:07:05 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 25E012BDB2; Wed, 21 Nov 2018 19:07:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B1B2B2B68D for ; Wed, 21 Nov 2018 19:07:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387566AbeKVFmf (ORCPT ); Thu, 22 Nov 2018 00:42:35 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:50910 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387645AbeKVFme (ORCPT ); Thu, 22 Nov 2018 00:42:34 -0500 Received: by mail-wm1-f68.google.com with SMTP id 125so6658844wmh.0 for ; Wed, 21 Nov 2018 11:07:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philpotter-co-uk.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=s2DDd3eT8uI17OfUO/qfYZtAyqcOnpiG2Q6vDRswi4w=; b=dWz/kU3e91NztzcMUzfvEyZQdZ8OYqDDjZ5FdGa3B8MOHnwdpMPQJlbQQJE8WZWDbu W51lXG67EMMKhORd6vedspBHZdiFKdNxE0jYSgLMJzon+QU5eZYxVWp6ZB+xf4965zRt FyQzQKk+oOdeUNGHRsVuIDfyRyD4OQgwaFj7ZXIMZv2+g5sZ0hXE9EoBvn7r47kr7rY1 H//8ODJWDrNOWDrFQ9SDmva8PcFC3V4lMkyEJRbXHScEk6KzGiLd6ZDnVkKl7lR70fTm svZqpMpDhrA0cw+jm3NOvG/RLgTZ+71LqPvamGwctqDNkTtFiL4c19/rLc3Lh0g+WQq9 xZXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=s2DDd3eT8uI17OfUO/qfYZtAyqcOnpiG2Q6vDRswi4w=; b=QkACmsqx2zL71Vjh8+ktulmGmbX3U6s/PjqFSaKbJ1Yo/sUrYDU1akMvH0gu5k9h9R rvZ2Z9fR+6ifWzZ5U4tL7084a0eKcoUStC+7VOtobxKwE01otQXLXJRtkHMnaGKf/ohc WC0Tvhv80maWpdD4mXywmVdUiVM5awzd4MU0e3kTEQDXjJRQEIJqnuwO0aDrAc5DnkeM YVRsEzKhPlO74aktpOQKQ+GzBiN6TDcvXHFoTP7MsMLkqNfFzIMQdAsNf3hBAUJbVzF4 7jewW2ymwbH/8Qcv8PrUwsS2rxE+5kzO1/Kt5CcG0n/h4XYy3IarjayJdwLKQWseVE0Z zmBg== X-Gm-Message-State: AA+aEWZrmAgHi8MEh8pDUO06u7SuMM44SARt741/BgisIvJA1pCu75Sk L75KkHfSvRYDiYRGCVNFmr5hwg== X-Google-Smtp-Source: AJdET5fHpRHhmsltMWcOsFP21acca/ZtBhSfvWLxQgx2lnqFdESAaaJjmNaOQ0flDPkx4M8LLPY3cA== X-Received: by 2002:a1c:ab07:: with SMTP id u7-v6mr6941703wme.16.1542827220891; Wed, 21 Nov 2018 11:07:00 -0800 (PST) Received: from pathfinder (62-64-249-96.dynamic.dsl.as9105.com. [62.64.249.96]) by smtp.gmail.com with ESMTPSA id b129sm1133938wmd.24.2018.11.21.11.06.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 21 Nov 2018 11:07:00 -0800 (PST) Date: Wed, 21 Nov 2018 19:06:59 +0000 From: Phillip Potter To: linux-nilfs@vger.kernel.org Cc: amir73il@gmail.com, viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org Subject: [RFC][PATCH v4 08/09] nilfs2: use common file type conversion Message-ID: <20181121190659.GA7738@pathfinder> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Deduplicate the nilfs2 file type conversion implementation - file systems that use the same file types as defined by POSIX do not need to define their own versions and can use the common helper functions decared in fs_types.h and implemented in fs_types.c Signed-off-by: Amir Goldstein Signed-off-by: Phillip Potter Reviewed-by: Jan Kara --- fs/nilfs2/dir.c | 52 ++++++++++-------------------- include/uapi/linux/nilfs2_ondisk.h | 1 + 2 files changed, 18 insertions(+), 35 deletions(-) diff --git a/fs/nilfs2/dir.c b/fs/nilfs2/dir.c index 81394e22d0a0..278d80d434b4 100644 --- a/fs/nilfs2/dir.c +++ b/fs/nilfs2/dir.c @@ -229,35 +229,23 @@ static struct nilfs_dir_entry *nilfs_next_entry(struct nilfs_dir_entry *p) nilfs_rec_len_from_disk(p->rec_len)); } -static unsigned char -nilfs_filetype_table[NILFS_FT_MAX] = { - [NILFS_FT_UNKNOWN] = DT_UNKNOWN, - [NILFS_FT_REG_FILE] = DT_REG, - [NILFS_FT_DIR] = DT_DIR, - [NILFS_FT_CHRDEV] = DT_CHR, - [NILFS_FT_BLKDEV] = DT_BLK, - [NILFS_FT_FIFO] = DT_FIFO, - [NILFS_FT_SOCK] = DT_SOCK, - [NILFS_FT_SYMLINK] = DT_LNK, -}; - -#define S_SHIFT 12 -static unsigned char -nilfs_type_by_mode[S_IFMT >> S_SHIFT] = { - [S_IFREG >> S_SHIFT] = NILFS_FT_REG_FILE, - [S_IFDIR >> S_SHIFT] = NILFS_FT_DIR, - [S_IFCHR >> S_SHIFT] = NILFS_FT_CHRDEV, - [S_IFBLK >> S_SHIFT] = NILFS_FT_BLKDEV, - [S_IFIFO >> S_SHIFT] = NILFS_FT_FIFO, - [S_IFSOCK >> S_SHIFT] = NILFS_FT_SOCK, - [S_IFLNK >> S_SHIFT] = NILFS_FT_SYMLINK, -}; - static void nilfs_set_de_type(struct nilfs_dir_entry *de, struct inode *inode) { - umode_t mode = inode->i_mode; - - de->file_type = nilfs_type_by_mode[(mode & S_IFMT)>>S_SHIFT]; + /* + * compile-time asserts that generic FT_x types still match + * NILFS_FT_x types + */ + BUILD_BUG_ON(NILFS_FT_UNKNOWN != FT_UNKNOWN); + BUILD_BUG_ON(NILFS_FT_REG_FILE != FT_REG_FILE); + BUILD_BUG_ON(NILFS_FT_DIR != FT_DIR); + BUILD_BUG_ON(NILFS_FT_CHRDEV != FT_CHRDEV); + BUILD_BUG_ON(NILFS_FT_BLKDEV != FT_BLKDEV); + BUILD_BUG_ON(NILFS_FT_FIFO != FT_FIFO); + BUILD_BUG_ON(NILFS_FT_SOCK != FT_SOCK); + BUILD_BUG_ON(NILFS_FT_SYMLINK != FT_SYMLINK); + BUILD_BUG_ON(NILFS_FT_MAX != FT_MAX); + + de->file_type = fs_umode_to_ftype(inode->i_mode); } static int nilfs_readdir(struct file *file, struct dir_context *ctx) @@ -293,15 +281,9 @@ static int nilfs_readdir(struct file *file, struct dir_context *ctx) return -EIO; } if (de->inode) { - unsigned char t; - - if (de->file_type < NILFS_FT_MAX) - t = nilfs_filetype_table[de->file_type]; - else - t = DT_UNKNOWN; - if (!dir_emit(ctx, de->name, de->name_len, - le64_to_cpu(de->inode), t)) { + le64_to_cpu(de->inode), + fs_ftype_to_dtype(de->file_type))) { nilfs_put_page(page); return 0; } diff --git a/include/uapi/linux/nilfs2_ondisk.h b/include/uapi/linux/nilfs2_ondisk.h index a7e66ab11d1d..9223b616766b 100644 --- a/include/uapi/linux/nilfs2_ondisk.h +++ b/include/uapi/linux/nilfs2_ondisk.h @@ -309,6 +309,7 @@ struct nilfs_dir_entry { /* * NILFS directory file types. Only the low 3 bits are used. The * other bits are reserved for now. + * Values must match common file type values in fs_types.h. */ enum { NILFS_FT_UNKNOWN,