diff mbox series

f2fs: fix block address for __check_sit_bitmap

Message ID 20181218093223.25242-1-sunqiuyang@huawei.com (mailing list archive)
State New, archived
Headers show
Series f2fs: fix block address for __check_sit_bitmap | expand

Commit Message

sunqiuyang Dec. 18, 2018, 9:32 a.m. UTC 
From: Qiuyang Sun <sunqiuyang@huawei.com>

Should use lstart (logical start address) instead of start (in dev) here.
This fixes a bug in multi-device scenarios.

Signed-off-by: Qiuyang Sun <sunqiuyang@huawei.com>
---
 fs/f2fs/segment.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Chao Yu Dec. 18, 2018, 10:36 a.m. UTC | #1 
On 2018/12/18 17:32, sunqiuyang wrote:
> From: Qiuyang Sun <sunqiuyang@huawei.com>
> 
> Should use lstart (logical start address) instead of start (in dev) here.
> This fixes a bug in multi-device scenarios.

Good catch!

> 
> Signed-off-by: Qiuyang Sun <sunqiuyang@huawei.com>

Reviewed-by: Chao Yu <yuchao0@huawei.com>

Thanks,
diff mbox series

Patch

diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index 204d31e..1a11e7e 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -1150,7 +1150,7 @@  static int __submit_discard_cmd(struct f2fs_sb_info *sbi,
 		list_move_tail(&dc->list, wait_list);
 
 		/* sanity check on discard range */
-		__check_sit_bitmap(sbi, start, start + len);
+		__check_sit_bitmap(sbi, lstart, lstart + len);
 
 		bio->bi_private = dc;
 		bio->bi_end_io = f2fs_submit_discard_endio;