diff mbox series

[RESEND] fs/nsfs.c: include linux/proc_fs.h for open_related_ns()

Message ID 20190110204150.120124-1-ebiggers@kernel.org (mailing list archive)
State New, archived
Headers show
Series [RESEND] fs/nsfs.c: include linux/proc_fs.h for open_related_ns() | expand

Commit Message

Eric Biggers Jan. 10, 2019, 8:41 p.m. UTC
From: Eric Biggers <ebiggers@google.com>

open_related_ns() is defined in fs/nsfs.c and declared in
linux/proc_fs.h, but the declaration isn't included at the point of the
definition.  Include the header to enforce that the definition matches
the declaration.

This addresses a gcc warning when -Wmissing-prototypes is enabled.

Signed-off-by: Eric Biggers <ebiggers@google.com>
---
 fs/nsfs.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Eric Biggers Feb. 7, 2019, 11:39 p.m. UTC | #1
On Thu, Jan 10, 2019 at 12:41:50PM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
> 
> open_related_ns() is defined in fs/nsfs.c and declared in
> linux/proc_fs.h, but the declaration isn't included at the point of the
> definition.  Include the header to enforce that the definition matches
> the declaration.
> 
> This addresses a gcc warning when -Wmissing-prototypes is enabled.
> 
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
>  fs/nsfs.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/nsfs.c b/fs/nsfs.c
> index 60702d677bd4e..a7ff518400a10 100644
> --- a/fs/nsfs.c
> +++ b/fs/nsfs.c
> @@ -2,6 +2,7 @@
>  #include <linux/mount.h>
>  #include <linux/file.h>
>  #include <linux/fs.h>
> +#include <linux/proc_fs.h>
>  #include <linux/proc_ns.h>
>  #include <linux/magic.h>
>  #include <linux/ktime.h>
> -- 
> 2.20.1.97.g81188d93c3-goog
> 

Ping.  Al, are you planning to apply this?

- Eric
diff mbox series

Patch

diff --git a/fs/nsfs.c b/fs/nsfs.c
index 60702d677bd4e..a7ff518400a10 100644
--- a/fs/nsfs.c
+++ b/fs/nsfs.c
@@ -2,6 +2,7 @@ 
 #include <linux/mount.h>
 #include <linux/file.h>
 #include <linux/fs.h>
+#include <linux/proc_fs.h>
 #include <linux/proc_ns.h>
 #include <linux/magic.h>
 #include <linux/ktime.h>