| Message ID | 20190110204153.120176-1-ebiggers@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [RESEND] fs/read_write.c: make __vfs_write() static | expand |
On Thu, Jan 10, 2019 at 12:41:53PM -0800, Eric Biggers wrote: > From: Eric Biggers <ebiggers@google.com> > > __vfs_write() is only used in fs/read_write.c, so make it static. > > This addresses a gcc warning when -Wmissing-prototypes is enabled. > > Signed-off-by: Eric Biggers <ebiggers@google.com> > --- > fs/read_write.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/read_write.c b/fs/read_write.c > index ff3c5e6f87cfa..4b328e45db366 100644 > --- a/fs/read_write.c > +++ b/fs/read_write.c > @@ -478,8 +478,8 @@ static ssize_t new_sync_write(struct file *filp, const char __user *buf, size_t > return ret; > } > > -ssize_t __vfs_write(struct file *file, const char __user *p, size_t count, > - loff_t *pos) > +static ssize_t __vfs_write(struct file *file, const char __user *p, > + size_t count, loff_t *pos) > { > if (file->f_op->write) > return file->f_op->write(file, p, count, pos); > -- > 2.20.1.97.g81188d93c3-goog > Ping. Al, are you planning to apply this? - Eric
diff --git a/fs/read_write.c b/fs/read_write.c index ff3c5e6f87cfa..4b328e45db366 100644 --- a/fs/read_write.c +++ b/fs/read_write.c @@ -478,8 +478,8 @@ static ssize_t new_sync_write(struct file *filp, const char __user *buf, size_t return ret; } -ssize_t __vfs_write(struct file *file, const char __user *p, size_t count, - loff_t *pos) +static ssize_t __vfs_write(struct file *file, const char __user *p, + size_t count, loff_t *pos) { if (file->f_op->write) return file->f_op->write(file, p, count, pos);