From patchwork Fri Jan 18 14:53:40 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Brauner X-Patchwork-Id: 10770545 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A2D7D91E for ; Fri, 18 Jan 2019 14:54:10 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 925BF2A035 for ; Fri, 18 Jan 2019 14:54:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 866D02A185; Fri, 18 Jan 2019 14:54:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0A2992A111 for ; Fri, 18 Jan 2019 14:54:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727631AbfAROyJ (ORCPT ); Fri, 18 Jan 2019 09:54:09 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:38866 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727599AbfAROyI (ORCPT ); Fri, 18 Jan 2019 09:54:08 -0500 Received: by mail-wr1-f66.google.com with SMTP id v13so15419580wrw.5 for ; Fri, 18 Jan 2019 06:54:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brauner.io; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JIu0gxheHpfHMGtY6RG0wmqCifwZppPWn7yXlpfF3JQ=; b=EmbAHrWDz3SMekBTo9S3HTxYzUPPtivAaQU0CMYuSJ6rdRaXF/naDeuRowQrEUrKIL aNePWVrTUuihoQmd8ER8zjt73DFDeqKJd7sX+e0ecfABh2jbcT68UYE08o6mmcxidYJ1 3SCpI6zn35EHvWApEJrUDXyYzRw3im1omsnJLYIVsKtJ5WQaAwt2TwiodOZaZ1z5UaRf Ev+qIOxKKbnsssNRmzrRmbJJe+lsmrp9pqE4iUg9kB/dylOBOeEYMUv1aLQwAKXq9duR KFqS71g8aREGwpyBuDs+O1y4iQ22qv7OldR9YRTlpsML6W3vkPpfzK1dgbE7LeMPRwIx 5KXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JIu0gxheHpfHMGtY6RG0wmqCifwZppPWn7yXlpfF3JQ=; b=Y1NAXcS1v0JQCWXrHDjvVGv1u8eOTttoDKDvAu7C78MhCl080sFi0ec2mpY9wMQe4N /z9xx2586UL61HMZxqU60rGjKynUaKqSkJ+jB0laTODCTcuhiOHktAvHgU/WXtN5KB67 2lRaYg1t4+TD/RfnNatomcidM4DvxKMxjqYhXgJAjBqdsejOK0vf0Izaq72pd4d5TXyo S9gUJOXin2gGoksUvyBIKno9Mly6Afjo4Sevh0O/QA37d76ye6kpFwAm2zHk7mjSjEEE Cvb/N1vLIUFqHuYcdmgHNoW4MmTtMYnOEMMjAJBOQ7XzdRdLRnRJV704YccZZ5O5vOsC ndfg== X-Gm-Message-State: AJcUukfOdkpwEqwxJ9JrGQv1yKRLG/cvytjpYiWqCcNEkohLmirsGxEg HBxX9VCUsZCEOcGcTRntd4PBJg== X-Google-Smtp-Source: ALg8bN5pUicTApvOFwjDNAxheQ1709rqBXxkvaKf3uiacUebglLzHo5Kn4YBzhsuY9s9/0T3xma4fg== X-Received: by 2002:a5d:6450:: with SMTP id d16mr16858877wrw.64.1547823247151; Fri, 18 Jan 2019 06:54:07 -0800 (PST) Received: from localhost.localdomain ([154.119.55.246]) by smtp.gmail.com with ESMTPSA id l15sm67655466wrw.4.2019.01.18.06.54.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Jan 2019 06:54:06 -0800 (PST) From: Christian Brauner To: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk Cc: tkjos@google.com, Christian Brauner Subject: [PATCH 1/5] binderfs: remove outdated comment Date: Fri, 18 Jan 2019 15:53:40 +0100 Message-Id: <20190118145344.11532-2-christian@brauner.io> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190118145344.11532-1-christian@brauner.io> References: <20190118145344.11532-1-christian@brauner.io> MIME-Version: 1.0 X-Patchwork-Bot: notify Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The comment stems from an early version of that patchset and is just confusing now. Cc: Al Viro Signed-off-by: Christian Brauner --- drivers/android/binderfs.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/android/binderfs.c b/drivers/android/binderfs.c index e4ff4c3fa371..898d847f8505 100644 --- a/drivers/android/binderfs.c +++ b/drivers/android/binderfs.c @@ -373,10 +373,6 @@ static int binderfs_rename(struct inode *old_dir, struct dentry *old_dentry, static int binderfs_unlink(struct inode *dir, struct dentry *dentry) { - /* - * The control dentry is only ever touched during mount so checking it - * here should not require us to take lock. - */ if (BINDERFS_I(dir)->control_dentry == dentry) return -EPERM;