From patchwork Mon Jan 21 10:48:02 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Brauner X-Patchwork-Id: 10773569 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3A4F391E for ; Mon, 21 Jan 2019 10:49:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 298E0298E3 for ; Mon, 21 Jan 2019 10:49:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1C7FE298F2; Mon, 21 Jan 2019 10:49:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C118F298E3 for ; Mon, 21 Jan 2019 10:49:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727743AbfAUKty (ORCPT ); Mon, 21 Jan 2019 05:49:54 -0500 Received: from mail-ed1-f66.google.com ([209.85.208.66]:46298 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727525AbfAUKtw (ORCPT ); Mon, 21 Jan 2019 05:49:52 -0500 Received: by mail-ed1-f66.google.com with SMTP id o10so16155712edt.13 for ; Mon, 21 Jan 2019 02:49:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brauner.io; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=igmVOJcPYkd/rUwG1V9gt69OEbVreyOqKw/vYFJWhM8=; b=VgQV/Z5MK3uo5d/68ek1XDsEzmn3qIF7RW9Q7iOQLt/1n/DRvPPdF+QNZizGQzRpqx F/YGsu6zapunS/t5d2XWAv1MSkprXmf+VaZNhmkMSeABL7UZjPD1xsndi1STYi1IeoML dnMK/dDeirpMlI8BBS/akO5qdfi/dy/XJ81+NbmwZmbqM1QylYnvlPLaKl5clM7JNi/p U5x4Kj+Of/hR/ubTpyeOnWo6cB46/Mz6YaRbyi9fiG/ScQOhoiEjTk30nDXoTe4JBAOm gYWNWuwimPFu9spN6iosAnSWlYtlwWUYIE4PskF5rqDTaK7GPN2KDNDvMGUp/7N2plUY LneQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=igmVOJcPYkd/rUwG1V9gt69OEbVreyOqKw/vYFJWhM8=; b=k3imEooAQRVgOOXBQbcQ5lphItSj4ACLl2xVNYi1q8d2tIUgoSZTC+ToTSviAEWRaF GtRUem5yXAApGDGufpVrKDX+6PQo6Oe78Vy6w0zhyt7GYXNaGE18aVnWxNhCMtBqt3+k v09ZFY15KufoJQj9Tw1u4QAUvxSxvbMEGfjcchQNCYnUKcJURuqRqT8L5nBx3CeIBgPI xZxK4TgXYbdRhfdNu5qGjHjc57kVCVcbXN9iI76iDUe+xi8qP1vJDmAXMsv1JlYSXD3y S3QCYoJ9P0zep98SyzfQzatlQvrrx+wxF6HINJlaCwslht+0sRkYOba0OttLqUcfHwk9 uBsA== X-Gm-Message-State: AJcUukeONVJZt/H5iIIGhpiUxtH7Xlnf+kZI0gUAmLUQBuAOJ6YTgI6z SbP5Qvsl3pueTXOxJhCS2eQ/IQ== X-Google-Smtp-Source: ALg8bN4juuojcH2Ayv5NjUvkY1P4VFJovVDtV3V1AZ5MBBtuGfW8NKQQAqjJleDRaLPkJD647MPXUw== X-Received: by 2002:a50:cc04:: with SMTP id m4mr26895087edi.171.1548067791176; Mon, 21 Jan 2019 02:49:51 -0800 (PST) Received: from localhost.localdomain ([2a02:8109:b6bf:f9e4:9473:6b39:afaf:14d4]) by smtp.gmail.com with ESMTPSA id e35sm9006196eda.13.2019.01.21.02.49.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Jan 2019 02:49:50 -0800 (PST) From: Christian Brauner To: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk, dhowells@redhat.com Cc: tkjos@google.com, Christian Brauner Subject: [PATCH v1 1/7] binderfs: remove outdated comment Date: Mon, 21 Jan 2019 11:48:02 +0100 Message-Id: <20190121104808.24108-2-christian@brauner.io> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190121104808.24108-1-christian@brauner.io> References: <20190121104808.24108-1-christian@brauner.io> MIME-Version: 1.0 X-Patchwork-Bot: notify Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The comment stems from an early version of that patchset and is just confusing now. Cc: Al Viro Signed-off-by: Christian Brauner --- /* Changelog */ v1: - patch unchanged --- drivers/android/binderfs.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/android/binderfs.c b/drivers/android/binderfs.c index e4ff4c3fa371..898d847f8505 100644 --- a/drivers/android/binderfs.c +++ b/drivers/android/binderfs.c @@ -373,10 +373,6 @@ static int binderfs_rename(struct inode *old_dir, struct dentry *old_dentry, static int binderfs_unlink(struct inode *dir, struct dentry *dentry) { - /* - * The control dentry is only ever touched during mount so checking it - * here should not require us to take lock. - */ if (BINDERFS_I(dir)->control_dentry == dentry) return -EPERM;