Message ID | 20190205191335.22056-2-hubcap@kernel.org (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | aio: intialize kiocb private | expand |
Didn't these catch the issue you fix in patch 2?
Yes, but I don't think they should be there. You put them into pvfs2_file_aio_read_iovec way back when (Martin guesses you were making sure that you had fully eradicated private's use) and I left them in when I changed that function over to pvfs2_file_read_iter. After that, they've just gone along for the ride... BUG_ONs that the maintainer can't justify might be the kind of thing that would make Linus violate the new code of conduct :-) ... -Mike On Wed, Feb 6, 2019 at 1:58 AM Christoph Hellwig <hch@lst.de> wrote: > > Didn't these catch the issue you fix in patch 2?
diff --git a/fs/orangefs/file.c b/fs/orangefs/file.c index a5a2fe76568f..b094d3d79354 100644 --- a/fs/orangefs/file.c +++ b/fs/orangefs/file.c @@ -398,8 +398,6 @@ static ssize_t orangefs_file_read_iter(struct kiocb *iocb, struct iov_iter *iter loff_t pos = iocb->ki_pos; ssize_t rc = 0; - BUG_ON(iocb->private); - gossip_debug(GOSSIP_FILE_DEBUG, "orangefs_file_read_iter\n"); orangefs_stats.reads++; @@ -416,8 +414,6 @@ static ssize_t orangefs_file_write_iter(struct kiocb *iocb, struct iov_iter *ite loff_t pos; ssize_t rc; - BUG_ON(iocb->private); - gossip_debug(GOSSIP_FILE_DEBUG, "orangefs_file_write_iter\n"); inode_lock(file->f_mapping->host);