| Message ID | 20190221222123.GC6474@magnolia (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | tmpfs: fix uninitialized return value in shmem_link | expand |
On Thu, Feb 21, 2019 at 2:21 PM Darrick J. Wong <darrick.wong@oracle.com> wrote: > > From: Darrick J. Wong <darrick.wong@oracle.com> > > When we made the shmem_reserve_inode call in shmem_link conditional, we > forgot to update the declaration for ret so that it always has a known > value. Dan Carpenter pointed out this deficiency in the original patch. > > Fixes: "tmpfs: fix link accounting when a tmpfile is linked in" > Reported-by: dan.carpenter@oracle.com > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> Gosh, yes indeed: thanks Dan and Darrick, I'm very sorry for not noticing that. Acked-by: Hugh Dickins <hughd@google.com> (and sorry if this mail is garbled: it's from gmail, I cannot use alpine at the moment). > --- > mm/shmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/shmem.c b/mm/shmem.c > index 0905215fb016..2c012eee133d 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -2848,7 +2848,7 @@ static int shmem_create(struct inode *dir, struct dentry *dentry, umode_t mode, > static int shmem_link(struct dentry *old_dentry, struct inode *dir, struct dentry *dentry) > { > struct inode *inode = d_inode(old_dentry); > - int ret; > + int ret = 0; > > /* > * No ordinary (disk based) filesystem counts links as inodes;
diff --git a/mm/shmem.c b/mm/shmem.c index 0905215fb016..2c012eee133d 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -2848,7 +2848,7 @@ static int shmem_create(struct inode *dir, struct dentry *dentry, umode_t mode, static int shmem_link(struct dentry *old_dentry, struct inode *dir, struct dentry *dentry) { struct inode *inode = d_inode(old_dentry); - int ret; + int ret = 0; /* * No ordinary (disk based) filesystem counts links as inodes;