| Message ID | 20190409060650.28901-1-jencce.kernel@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | fs/aio.c: fix wrong return value regression in __io_submit_one | expand |
On Tue, Apr 09, 2019 at 02:06:50PM +0800, Murphy Zhou wrote: > Now it returns 0 when actually error happened, causing kernel hang easily. > > Fixes: 7316b49 "aio: move sanity checks and request allocation to io_submit_one()" > Signed-off-by: Murphy Zhou <jencce.kernel@gmail.com> See 18bfb9c6a8a5 (aio: Fix an error code in __io_submit_one()) in vfs.git#fixes...
On Wed, Apr 10, 2019 at 7:13 AM Al Viro <viro@zeniv.linux.org.uk> wrote: > > On Tue, Apr 09, 2019 at 02:06:50PM +0800, Murphy Zhou wrote: > > Now it returns 0 when actually error happened, causing kernel hang easily. > > > > Fixes: 7316b49 "aio: move sanity checks and request allocation to io_submit_one()" > > Signed-off-by: Murphy Zhou <jencce.kernel@gmail.com> > > See 18bfb9c6a8a5 (aio: Fix an error code in __io_submit_one()) in > vfs.git#fixes... Got it, Thanks!
diff --git a/fs/aio.c b/fs/aio.c index a4cc2a1cccb7..7ccecaab487a 100644 --- a/fs/aio.c +++ b/fs/aio.c @@ -1794,7 +1794,7 @@ static int __io_submit_one(struct kioctx *ctx, const struct iocb *iocb, */ eventfd = eventfd_ctx_fdget(iocb->aio_resfd); if (IS_ERR(eventfd)) - return PTR_ERR(req->ki_eventfd); + return PTR_ERR(eventfd); req->ki_eventfd = eventfd; }
Now it returns 0 when actually error happened, causing kernel hang easily. Fixes: 7316b49 "aio: move sanity checks and request allocation to io_submit_one()" Signed-off-by: Murphy Zhou <jencce.kernel@gmail.com> --- fs/aio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)