diff mbox series

[05/12] statx: don't clear STATX_ATIME on SB_RDONLY

Message ID 20191128155940.17530-6-mszeredi@redhat.com
State New
Headers show
Series various vfs patches | expand

Commit Message

Miklos Szeredi Nov. 28, 2019, 3:59 p.m. UTC
IS_NOATIME(inode) is defined as __IS_FLG(inode, SB_RDONLY|SB_NOATIME), so
generic_fillattr() will clear STATX_ATIME from the result_mask if the super
block is marked read only.

This was probably not the intention, so fix to only clear STATX_ATIME if
the fs doesn't support atime at all.

Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Acked-by: David Howells <dhowells@redhat.com>
 fs/stat.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff mbox series


diff --git a/fs/stat.c b/fs/stat.c
index 7899d15722a0..fc49f705a83c 100644
--- a/fs/stat.c
+++ b/fs/stat.c
@@ -71,7 +71,8 @@  int vfs_getattr_nosec(const struct path *path, struct kstat *stat,
 	query_flags &= KSTAT_QUERY_FLAGS;
 	/* allow the fs to override these if it really wants to */
-	if (IS_NOATIME(inode))
+	/* SB_NOATIME means filesystem supplies dummy atime value */
+	if (inode->i_sb->s_flags & SB_NOATIME)
 		stat->result_mask &= ~STATX_ATIME;
 	if (IS_AUTOMOUNT(inode))
 		stat->attributes |= STATX_ATTR_AUTOMOUNT;