From patchwork Thu Apr 9 16:53:52 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johannes Thumshirn X-Patchwork-Id: 11482061 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A877F1871 for ; Thu, 9 Apr 2020 16:54:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8974520769 for ; Thu, 9 Apr 2020 16:54:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=wdc.com header.i=@wdc.com header.b="iQ3glxeB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728134AbgDIQyQ (ORCPT ); Thu, 9 Apr 2020 12:54:16 -0400 Received: from esa6.hgst.iphmx.com ([216.71.154.45]:24729 "EHLO esa6.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727878AbgDIQyO (ORCPT ); Thu, 9 Apr 2020 12:54:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1586451254; x=1617987254; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=DntH3FOL+F2qJ4JB8bNfeHvJeRnIrbJq4X8RpN63JaA=; b=iQ3glxeBXBKjcW6mGQomEUPIYeZO2ch0KO1sF4Ao+0km+/oVVDjmpOKE VzTtp/QPVXIglru5IWlP1JoDt3Hbxd0kSD/3RmvDv0BYBqcSBTWSgxM4s +nL7Nyw9DhD7Iv196PbxE7Qae8aKYr+ZNnwRRJ6RdRFXRhZcht+/YchSm NG+ycskdXhZMgd0QvvUoM33wZWfzvIshpyNDz3Xp8FEv7JH74YPzKxDkK qHVrfxBF2EnI0SsnVsUod4/vqfUc7+hfCjpC/JEc+GvfLsNjoSa9VcsqY aFnSr8BEsEYRMvbbHXIfU1R2qoTkrwqwdFEds3aPaJROYhUdjjFONLOWO g==; IronPort-SDR: P+jja9En4szPyF6RN278XRQ/3w4o8kHMb1GzNf2Joxo/cgPlzA7rXEx4RSXcYBtGl+6jqFdm7y Q8SNGphGe67cpo9FAbg3LNGcKncRqdyjdGdZu3wjMURx0kW80IIZtvF4AyvobJPA+Iz0CNhBm0 Yk7eDRYqQU9w4hfPkIdBrQ2LnpjuuFvVpB9abfgu1MiVbkyHOFqkttaAp5vQlnNb6BBMT81OXJ 21fV2tv0flo1KK/X+2WJjS4fE50p+yXoYUo4bjHo/mOMUhsuq+RiXcMgEnTzx/1Is0APVz2qzz O4U= X-IronPort-AV: E=Sophos;i="5.72,363,1580745600"; d="scan'208";a="136423706" Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 10 Apr 2020 00:54:14 +0800 IronPort-SDR: Y0yjE/uAPjs6U72F80v9dnwuR/3KWTrmwzf+rdT2m7V8BR9+Rn22zk3gcnatEaKzh6owKvvN/7 R+3ykxQ7Moex5X16l1igEEIQeTrUa0l2gryB9ngV37AxhdZaDvmKa3B6IDdl3HbthGV8gd9DPl Y+uaw8MkxDz69LsntnnGXA6nNQd2q998ai3uvUp8/bjACqGq6lHGRO2PKeqVYBB4mgQCVha66N KJSnrC7nIbhQfNY2sNxlwyk4eXIB/W9mdAfbQsL++yBsQUFDUmarVbNB+SIt4Pg40pBg/YExv4 iTkZ/BoTfdqcbB9WmJst9Zmo Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2020 09:44:53 -0700 IronPort-SDR: NHV6vZzxltP47OwkQ54VnvpTBjp3Czrekz+QikxdevLcZD+4Y/14HslBI9Sr7yygh+shbWRiKM 2DybP7Fa3yXVaxkPuxzK/6E3lzRHULeK3tiGzNXm3KBSdvhFqPYf9Wf9Ao7+jKHtyxdNNRn5FS oGRWEv+c15SUXOJW1EHr2Uk5WoSCV9d/XOtOj/vBmc5mWAZmWU/l9zHhnJDZYOwHuTHunG2TvB 506WS0SSvTSQWWr13MnDLSenZ0PLuM29C9hCORENr6kI2b0oexODDjbJQXwpxjOvUUuIL7wlPa GPw= WDCIronportException: Internal Received: from unknown (HELO redsun60.ssa.fujisawa.hgst.com) ([10.149.66.36]) by uls-op-cesaip02.wdc.com with ESMTP; 09 Apr 2020 09:54:13 -0700 From: Johannes Thumshirn To: Jens Axboe Cc: Christoph Hellwig , linux-block , Damien Le Moal , Keith Busch , "linux-scsi @ vger . kernel . org" , "Martin K . Petersen" , "linux-fsdevel @ vger . kernel . org" , Johannes Thumshirn Subject: [PATCH v5 10/10] zonefs: use REQ_OP_ZONE_APPEND for sync DIO Date: Fri, 10 Apr 2020 01:53:52 +0900 Message-Id: <20200409165352.2126-11-johannes.thumshirn@wdc.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200409165352.2126-1-johannes.thumshirn@wdc.com> References: <20200409165352.2126-1-johannes.thumshirn@wdc.com> MIME-Version: 1.0 Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Synchronous direct I/O to a sequential write only zone can be issued using the new REQ_OP_ZONE_APPEND request operation. As dispatching multiple BIOs can potentially result in reordering, we cannot support asynchronous IO via this interface. We also can only dispatch up to queue_max_zone_append_sectors() via the new zone-append method and have to return a short write back to user-space in case an IO larger than queue_max_zone_append_sectors() has been issued. Signed-off-by: Johannes Thumshirn --- fs/zonefs/super.c | 80 ++++++++++++++++++++++++++++++++++++++++++----- 1 file changed, 72 insertions(+), 8 deletions(-) diff --git a/fs/zonefs/super.c b/fs/zonefs/super.c index 3ce9829a6936..0bf7009f50a2 100644 --- a/fs/zonefs/super.c +++ b/fs/zonefs/super.c @@ -20,6 +20,7 @@ #include #include #include +#include #include "zonefs.h" @@ -596,6 +597,61 @@ static const struct iomap_dio_ops zonefs_write_dio_ops = { .end_io = zonefs_file_write_dio_end_io, }; +static ssize_t zonefs_file_dio_append(struct kiocb *iocb, struct iov_iter *from) +{ + struct inode *inode = file_inode(iocb->ki_filp); + struct zonefs_inode_info *zi = ZONEFS_I(inode); + struct block_device *bdev = inode->i_sb->s_bdev; + unsigned int max; + struct bio *bio; + ssize_t size; + int nr_pages; + ssize_t ret; + + nr_pages = iov_iter_npages(from, BIO_MAX_PAGES); + if (!nr_pages) + return 0; + + max = queue_max_zone_append_sectors(bdev_get_queue(bdev)); + max = ALIGN_DOWN(max << SECTOR_SHIFT, inode->i_sb->s_blocksize); + iov_iter_truncate(from, max); + + bio = bio_alloc_bioset(GFP_NOFS, nr_pages, &fs_bio_set); + if (!bio) + return -ENOMEM; + + bio_set_dev(bio, bdev); + bio->bi_iter.bi_sector = zi->i_zsector; + bio->bi_write_hint = iocb->ki_hint; + bio->bi_ioprio = iocb->ki_ioprio; + bio->bi_opf = REQ_OP_ZONE_APPEND | REQ_SYNC | REQ_IDLE; + if (iocb->ki_flags & IOCB_DSYNC) + bio->bi_opf |= REQ_FUA; + + ret = bio_iov_iter_get_pages(bio, from); + if (unlikely(ret)) { + bio_io_error(bio); + return ret; + } + size = bio->bi_iter.bi_size; + task_io_account_write(ret); + + if (iocb->ki_flags & IOCB_HIPRI) + bio_set_polled(bio, iocb); + + ret = submit_bio_wait(bio); + + bio_put(bio); + + zonefs_file_write_dio_end_io(iocb, size, ret, 0); + if (ret >= 0) { + iocb->ki_pos += size; + return size; + } + + return ret; +} + /* * Handle direct writes. For sequential zone files, this is the only possible * write path. For these files, check that the user is issuing writes @@ -611,6 +667,8 @@ static ssize_t zonefs_file_dio_write(struct kiocb *iocb, struct iov_iter *from) struct inode *inode = file_inode(iocb->ki_filp); struct zonefs_inode_info *zi = ZONEFS_I(inode); struct super_block *sb = inode->i_sb; + bool sync = is_sync_kiocb(iocb); + bool append = false; size_t count; ssize_t ret; @@ -619,7 +677,7 @@ static ssize_t zonefs_file_dio_write(struct kiocb *iocb, struct iov_iter *from) * as this can cause write reordering (e.g. the first aio gets EAGAIN * on the inode lock but the second goes through but is now unaligned). */ - if (zi->i_ztype == ZONEFS_ZTYPE_SEQ && !is_sync_kiocb(iocb) && + if (zi->i_ztype == ZONEFS_ZTYPE_SEQ && !sync && (iocb->ki_flags & IOCB_NOWAIT)) return -EOPNOTSUPP; @@ -643,16 +701,22 @@ static ssize_t zonefs_file_dio_write(struct kiocb *iocb, struct iov_iter *from) } /* Enforce sequential writes (append only) in sequential zones */ - mutex_lock(&zi->i_truncate_mutex); - if (zi->i_ztype == ZONEFS_ZTYPE_SEQ && iocb->ki_pos != zi->i_wpoffset) { + if (zi->i_ztype == ZONEFS_ZTYPE_SEQ) { + mutex_lock(&zi->i_truncate_mutex); + if (iocb->ki_pos != zi->i_wpoffset) { + mutex_unlock(&zi->i_truncate_mutex); + ret = -EINVAL; + goto inode_unlock; + } mutex_unlock(&zi->i_truncate_mutex); - ret = -EINVAL; - goto inode_unlock; + append = sync; } - mutex_unlock(&zi->i_truncate_mutex); - ret = iomap_dio_rw(iocb, from, &zonefs_iomap_ops, - &zonefs_write_dio_ops, is_sync_kiocb(iocb)); + if (append) + ret = zonefs_file_dio_append(iocb, from); + else + ret = iomap_dio_rw(iocb, from, &zonefs_iomap_ops, + &zonefs_write_dio_ops, sync); if (zi->i_ztype == ZONEFS_ZTYPE_SEQ && (ret > 0 || ret == -EIOCBQUEUED)) { if (ret > 0)