diff mbox series

[12/12] vfs: don't parse "silent" option

Message ID 20200505095915.11275-13-mszeredi@redhat.com (mailing list archive)
State New, archived
Headers show
Series vfs patch queue | expand

Commit Message

Miklos Szeredi May 5, 2020, 9:59 a.m. UTC 
Parsing "silent" and clearing SB_SILENT makes zero sense.

Parsing "silent" and setting SB_SILENT would make a bit more sense, but
apparently nobody cares.

Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
---
 fs/fs_context.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Christoph Hellwig May 13, 2020, 10:07 a.m. UTC | #1 
On Tue, May 05, 2020 at 11:59:15AM +0200, Miklos Szeredi wrote:
> Parsing "silent" and clearing SB_SILENT makes zero sense.
> 
> Parsing "silent" and setting SB_SILENT would make a bit more sense, but
> apparently nobody cares.
> 
> Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>

Looksgood,

Reviewed-by: Christoph Hellwig <hch@lst.de>
diff mbox series

Patch

diff --git a/fs/fs_context.c b/fs/fs_context.c
index 82019569d493..7d5c5dd2b1d5 100644
--- a/fs/fs_context.c
+++ b/fs/fs_context.c
@@ -52,7 +52,6 @@  static const struct constant_table common_clear_sb_flag[] = {
 	{ "nolazytime",	SB_LAZYTIME },
 	{ "nomand",	SB_MANDLOCK },
 	{ "rw",		SB_RDONLY },
-	{ "silent",	SB_SILENT },
 	{ },
 };