Message ID | 20200505095915.11275-8-mszeredi@redhat.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | vfs patch queue | expand |
On Tue, May 05, 2020 at 11:59:10AM +0200, Miklos Szeredi wrote: > IS_NOATIME(inode) is defined as __IS_FLG(inode, SB_RDONLY|SB_NOATIME), so > generic_fillattr() will clear STATX_ATIME from the result_mask if the super > block is marked read only. > > This was probably not the intention, so fix to only clear STATX_ATIME if > the fs doesn't support atime at all. > > Signed-off-by: Miklos Szeredi <mszeredi@redhat.com> > Acked-by: David Howells <dhowells@redhat.com> Looks good, Reviewed-by: Christoph Hellwig <hch@lst.de>
diff --git a/fs/stat.c b/fs/stat.c index a6709e7ba71d..f7f07d1b73cb 100644 --- a/fs/stat.c +++ b/fs/stat.c @@ -73,7 +73,8 @@ int vfs_getattr_nosec(const struct path *path, struct kstat *stat, query_flags &= KSTAT_QUERY_FLAGS; /* allow the fs to override these if it really wants to */ - if (IS_NOATIME(inode)) + /* SB_NOATIME means filesystem supplies dummy atime value */ + if (inode->i_sb->s_flags & SB_NOATIME) stat->result_mask &= ~STATX_ATIME; if (IS_AUTOMOUNT(inode)) stat->attributes |= STATX_ATTR_AUTOMOUNT;