[12/20] omapfb: get rid of pointless access_ok() calls

Message ID	20200509234557.1124086-12-viro@ZenIV.linux.org.uk (mailing list archive)
State	New, archived
Headers	show Return-Path: <SRS0=MqLL=6X=vger.kernel.org=linux-fsdevel-owner@kernel.org> From: Al Viro <viro@ZenIV.linux.org.uk> To: linux-kernel@vger.kernel.org Cc: Linus Torvalds <torvalds@linux-foundation.org>, linux-fsdevel@vger.kernel.org, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Subject: [PATCH 12/20] omapfb: get rid of pointless access_ok() calls Date: Sun, 10 May 2020 00:45:49 +0100 Message-Id: <20200509234557.1124086-12-viro@ZenIV.linux.org.uk> In-Reply-To: <20200509234557.1124086-1-viro@ZenIV.linux.org.uk> References: <20200509234124.GM23230@ZenIV.linux.org.uk> <20200509234557.1124086-1-viro@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk
Series	[01/20] dlmfs_file_write(): get rid of pointless access_ok() \| expand [01/20] dlmfs_file_write(): get rid of pointless access_ok() [02/20] fat_dir_ioctl(): hadn't needed that access_ok() for more than a decade... [03/20] btrfs_ioctl_send(): don't bother with access_ok() [05/20] tomoyo_write_control(): get rid of pointless access_ok() [06/20] n_hdlc_tty_read(): remove pointless access_ok() [07/20] nvram: drop useless access_ok() [08/20] cm4000_cs.c cmm_ioctl(): get rid of pointless access_ok() [09/20] drivers/fpga/dfl-fme-pr.c: get rid of pointless access_ok() [10/20] drivers/fpga/dfl-afu-dma-region.c: get rid of pointless access_ok() [11/20] amifb: get rid of pointless access_ok() calls [12/20] omapfb: get rid of pointless access_ok() calls [13/20] drivers/crypto/ccp/sev-dev.c: get rid of pointless access_ok() [14/20] via-pmu: don't bother with access_ok() [15/20] drm_read(): get rid of pointless access_ok() [16/20] efi_test: get rid of pointless access_ok() [17/20] lpfc_debugfs: get rid of pointless access_ok() [18/20] usb: get rid of pointless access_ok() calls [19/20] hfi1: get rid of pointless access_ok() [4/4] vmci_host: get rid of pointless access_ok()

Message ID

20200509234557.1124086-12-viro@ZenIV.linux.org.uk (mailing list archive)

State

New, archived

Headers

From: Al Viro <viro@ZenIV.linux.org.uk>
To: linux-kernel@vger.kernel.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
        linux-fsdevel@vger.kernel.org,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: [PATCH 12/20] omapfb: get rid of pointless access_ok() calls
Date: Sun, 10 May 2020 00:45:49 +0100
Message-Id: <20200509234557.1124086-12-viro@ZenIV.linux.org.uk>
In-Reply-To: <20200509234557.1124086-1-viro@ZenIV.linux.org.uk>
References: <20200509234124.GM23230@ZenIV.linux.org.uk>
 <20200509234557.1124086-1-viro@ZenIV.linux.org.uk>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-fsdevel-owner@vger.kernel.org
Precedence: bulk

Series

[01/20] dlmfs_file_write(): get rid of pointless access_ok() | expand

From: Al Viro <viro@zeniv.linux.org.uk> address is passed only to copy_to_user() Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> --- drivers/video/fbdev/omap2/omapfb/omapfb-ioctl.c | 3 --- 1 file changed, 3 deletions(-)

Comments

Bartlomiej Zolnierkiewicz May 14, 2020, 1:39 p.m. UTC | #1

On 5/10/20 1:45 AM, Al Viro wrote:
> From: Al Viro <viro@zeniv.linux.org.uk>
> 
> address is passed only to copy_to_user()
> 
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

> ---
>  drivers/video/fbdev/omap2/omapfb/omapfb-ioctl.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/video/fbdev/omap2/omapfb/omapfb-ioctl.c b/drivers/video/fbdev/omap2/omapfb/omapfb-ioctl.c
> index 56995f44e76d..f40be68d5aac 100644
> --- a/drivers/video/fbdev/omap2/omapfb/omapfb-ioctl.c
> +++ b/drivers/video/fbdev/omap2/omapfb/omapfb-ioctl.c
> @@ -482,9 +482,6 @@ static int omapfb_memory_read(struct fb_info *fbi,
>  	if (!display || !display->driver->memory_read)
>  		return -ENOENT;
>  
> -	if (!access_ok(mr->buffer, mr->buffer_size))
> -		return -EFAULT;
> -
>  	if (mr->w > 4096 || mr->h > 4096)
>  		return -EINVAL;
>  
>

diff --git a/drivers/video/fbdev/omap2/omapfb/omapfb-ioctl.c b/drivers/video/fbdev/omap2/omapfb/omapfb-ioctl.c
index 56995f44e76d..f40be68d5aac 100644
--- a/drivers/video/fbdev/omap2/omapfb/omapfb-ioctl.c
+++ b/drivers/video/fbdev/omap2/omapfb/omapfb-ioctl.c
@@ -482,9 +482,6 @@  static int omapfb_memory_read(struct fb_info *fbi,
 	if (!display || !display->driver->memory_read)
 		return -ENOENT;
 
-	if (!access_ok(mr->buffer, mr->buffer_size))
-		return -EFAULT;
-
 	if (mr->w > 4096 || mr->h > 4096)
 		return -EINVAL;

[12/20] omapfb: get rid of pointless access_ok() calls

Commit Message

Comments

Patch