[05/14] mm: add struct address_space to writepage() callback

From: Jérôme Glisse <jglisse@redhat.com>

From: Jérôme Glisse <jglisse@redhat.com>

This is part of patchset to remove dependency on struct page.mapping
field so that we can temporarily update it to point to a special
structure tracking temporary page state (note that original mapping
pointer is preserved and can still be accessed but at a cost).

Add struct address_space to writepage() callback arguments.

Note that this patch does not make use of the new argument, nor does
it use a valid one at call site (by default this patch just use NULL
for new argument value).

Use following script (from root of linux kernel tree):

./that-script.sh that-semantic-patch.spatch

%<--------------------------------------------------------------------
#!/bin/sh
spatch_file=$1

echo PART1 ===========================================================

# P1 find callback functions name
spatch  --dir . --no-includes -D part1 --sp-file $spatch_file

echo PART2 ===========================================================

# P2 change callback function prototype
cat /tmp/unicorn-functions | sort | uniq | while read func ; do
    for file in $( git grep -l $func -- '*.[ch]' ) ; do
        echo $file
        spatch --no-includes --in-place -D part2 \
               -D fn=$func --sp-file $spatch_file $file
    done
done

echo PART 3 ==========================================================

# P3 find all function which call the callback
spatch --dir . --include-headers -D part3 --sp-file $spatch_file

echo PART 4===========================================================

# P4 change all funcitons which call the callback
cat /tmp/unicorn-files | sort | uniq | while read file ; do
    echo $file
    spatch --no-includes --in-place -D part4 \
           --sp-file $spatch_file $file
done
-------------------------------------------------------------------->%

With the following semantic patch:

%<--------------------------------------------------------------------
virtual part1, part2, part3, part4

// ----------------------------------------------------------------------------
// Part 1 is grepping all function that are use as callback for writepage.

// initialize file where we collect all function name (erase it)
@initialize:python depends on part1@
@@
file=open('/tmp/unicorn-functions', 'w')
file.close()

// match function name use as a callback
@p1r2 depends on part1@
identifier I1, FN;
@@
struct address_space_operations I1 = {..., .writepage = FN, ...};

@script:python p1r3 depends on p1r2@
funcname << p1r2.FN;
@@
if funcname != "NULL":
  file=open('/tmp/unicorn-functions', 'a')
  file.write(funcname + '\n')
  file.close()

// -------------------------------------------------------------------
// Part 2 modify callback

// Add address_space argument to the function (writepage callback one)
@p2r1 depends on part2@
identifier virtual.fn;
identifier I1, I2;
type T1, T2;
@@
int fn(
+struct address_space *__mapping,
T1 I1, T2 I2) { ... }

@p2r2 depends on part2@
identifier virtual.fn;
identifier I1, I2;
type T1, T2;
@@
int fn(
+struct address_space *__mapping,
T1 I1, T2 I2);

@p2r3 depends on part2@
identifier virtual.fn;
type T1, T2;
@@
int fn(
+struct address_space *__mapping,
T1, T2);

@p2r4 depends on part2@
identifier virtual.fn;
expression E1, E2;
@@
fn(
+MAPPING_NULL,
E1, E2)

// ----------------------------------------------------------------------------
// Part 3 is grepping all function that are use the callback for writepage.

// initialize file where we collect all function name (erase it)
@initialize:python depends on part3@
@@
file=open('/tmp/unicorn-files', 'w')
file.write("./include/linux/pagemap.h\n")
file.write("./include/linux/mm.h\n")
file.write("./include/linux/fs.h\n")
file.write("./mm/readahead.c\n")
file.write("./mm/filemap.c\n")
file.close()

@p3r1 depends on part3 exists@
expression E1, E2, E3;
identifier FN;
position P;
@@
FN@P(...) {...
(
E1.a_ops->writepage(E2, E3)
|
E1->a_ops->writepage(E2, E3)
)
...}

@script:python p3r2 depends on p3r1@
P << p3r1.P;
@@
file=open('/tmp/unicorn-files', 'a')
file.write(P[0].file + '\n')
file.close()

// -------------------------------------------------------------------
// Part 4 generic modification
@p4r1 depends on part4@
@@
struct address_space_operations { ... int (*writepage)(
+struct address_space *,
struct page *page, ...); ... };

@p4r2 depends on part4@
expression E1, E2, E3;
@@
E1.a_ops->writepage(
+MAPPING_NULL,
E2, E3)

@p4r3 depends on part4@
expression E1, E2, E3;
@@
E1->a_ops->writepage(
+MAPPING_NULL,
E2, E3)
-------------------------------------------------------------------->%

Signed-off-by: Jérôme Glisse <jglisse@redhat.com>
Cc: linux-mm@kvack.org
Cc: linux-fsdevel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org
Cc: Tejun Heo <tj@kernel.org>
Cc: Jan Kara <jack@suse.cz>
Cc: Josef Bacik <jbacik@fb.com>
---
 drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 3 ++-
 fs/9p/vfs_addr.c                          | 4 +++-
 fs/adfs/inode.c                           | 3 ++-
 fs/affs/file.c                            | 3 ++-
 fs/afs/internal.h                         | 3 ++-
 fs/afs/write.c                            | 3 ++-
 fs/bfs/file.c                             | 3 ++-
 fs/block_dev.c                            | 3 ++-
 fs/btrfs/inode.c                          | 3 ++-
 fs/ceph/addr.c                            | 3 ++-
 fs/cifs/file.c                            | 3 ++-
 fs/ecryptfs/mmap.c                        | 4 +++-
 fs/exfat/inode.c                          | 3 ++-
 fs/ext2/inode.c                           | 8 +++++---
 fs/ext4/inode.c                           | 2 +-
 fs/f2fs/checkpoint.c                      | 3 ++-
 fs/f2fs/data.c                            | 3 ++-
 fs/f2fs/node.c                            | 3 ++-
 fs/fat/inode.c                            | 3 ++-
 fs/fuse/file.c                            | 3 ++-
 fs/gfs2/aops.c                            | 7 +++++--
 fs/gfs2/meta_io.c                         | 4 +++-
 fs/hfs/inode.c                            | 3 ++-
 fs/hfsplus/inode.c                        | 3 ++-
 fs/hostfs/hostfs_kern.c                   | 3 ++-
 fs/hpfs/file.c                            | 3 ++-
 fs/jfs/inode.c                            | 3 ++-
 fs/jfs/jfs_metapage.c                     | 4 +++-
 fs/minix/inode.c                          | 3 ++-
 fs/mpage.c                                | 2 +-
 fs/nfs/write.c                            | 3 ++-
 fs/nilfs2/inode.c                         | 3 ++-
 fs/nilfs2/mdt.c                           | 3 ++-
 fs/ntfs/aops.c                            | 3 ++-
 fs/ocfs2/aops.c                           | 3 ++-
 fs/omfs/file.c                            | 3 ++-
 fs/orangefs/inode.c                       | 4 +++-
 fs/reiserfs/inode.c                       | 4 +++-
 fs/sysv/itree.c                           | 3 ++-
 fs/ubifs/file.c                           | 3 ++-
 fs/udf/file.c                             | 3 ++-
 fs/udf/inode.c                            | 5 +++--
 fs/ufs/inode.c                            | 3 ++-
 fs/vboxsf/file.c                          | 3 ++-
 fs/xfs/xfs_aops.c                         | 2 +-
 fs/zonefs/super.c                         | 3 ++-
 include/linux/fs.h                        | 3 ++-
 include/linux/nfs_fs.h                    | 3 ++-
 include/linux/swap.h                      | 7 +++++--
 mm/migrate.c                              | 2 +-
 mm/page-writeback.c                       | 4 ++--
 mm/page_io.c                              | 3 ++-
 mm/shmem.c                                | 5 +++--
 mm/vmscan.c                               | 2 +-
 54 files changed, 120 insertions(+), 61 deletions(-)

Message ID	20201007010603.3452458-6-jglisse@redhat.com (mailing list archive)
State	New, archived
Headers	show Return-Path: <SRS0=d070=DO=vger.kernel.org=linux-fsdevel-owner@kernel.org> Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 80DA614D5 for <patchwork-linux-fsdevel@patchwork.kernel.org>; Wed, 7 Oct 2020 01:07:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4DDF2207EA for <patchwork-linux-fsdevel@patchwork.kernel.org>; Wed, 7 Oct 2020 01:07:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Mf6noy3F" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727353AbgJGBHe (ORCPT <rfc822;patchwork-linux-fsdevel@patchwork.kernel.org>); Tue, 6 Oct 2020 21:07:34 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:51584 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727261AbgJGBHc (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>); Tue, 6 Oct 2020 21:07:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602032849; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Oj1J5z5H8I/P159EdJkp/eoU7pYGDRFNShpqo+JUQzE=; b=Mf6noy3F8rH2KuvzBQQYj5FE7+M1dx2CXGVsi5Doi+l/VgQOdqBOcQPZf49Oac7i50fxoE fHIc6cO1dstIrsexdtEFee/fBxmVq3V6CTZrw3r153ZPpOpwqf1PUZbY4brcmtt0tI2pqY U64UZAEWvb4ATyCw5KI7MPlIfu6q2is= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-591-5XBVyk55OEmmE-aC95Owaw-1; Tue, 06 Oct 2020 21:07:26 -0400 X-MC-Unique: 5XBVyk55OEmmE-aC95Owaw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E467B100854F; Wed, 7 Oct 2020 01:07:24 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-119-161.rdu2.redhat.com [10.10.119.161]) by smtp.corp.redhat.com (Postfix) with ESMTP id D82545D9D2; Wed, 7 Oct 2020 01:07:18 +0000 (UTC) From: jglisse@redhat.com To: linux-kernel@vger.kernel.org Cc: =?utf-8?b?SsOpcsO0bWUgR2xpc3Nl?= <jglisse@redhat.com>, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>, Alexander Viro <viro@zeniv.linux.org.uk>, Tejun Heo <tj@kernel.org>, Jan Kara <jack@suse.cz>, Josef Bacik <jbacik@fb.com> Subject: [PATCH 05/14] mm: add struct address_space to writepage() callback Date: Tue, 6 Oct 2020 21:05:54 -0400 Message-Id: <20201007010603.3452458-6-jglisse@redhat.com> In-Reply-To: <20201007010603.3452458-1-jglisse@redhat.com> References: <20201007010603.3452458-1-jglisse@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Precedence: bulk List-ID: <linux-fsdevel.vger.kernel.org> X-Mailing-List: linux-fsdevel@vger.kernel.org
Series	Small step toward KSM for file back page. \| expand [00/14] Small step toward KSM for file back page. [01/14] mm/pxa: page exclusive access add header file for all helpers. [02/14] fs: define filler_t as a function pointer type [03/14] fs: directly use a_ops->freepage() instead of a local copy of it. [04/14] mm: add struct address_space to readpage() callback [05/14] mm: add struct address_space to writepage() callback [06/14] mm: add struct address_space to set_page_dirty() callback [07/14] mm: add struct address_space to invalidatepage() callback [08/14] mm: add struct address_space to releasepage() callback [09/14] mm: add struct address_space to freepage() callback [10/14] mm: add struct address_space to putback_page() callback [11/14] mm: add struct address_space to launder_page() callback [12/14] mm: add struct address_space to is_partially_uptodate() callback [13/14] mm: add struct address_space to isolate_page() callback [14/14] mm: add struct address_space to is_dirty_writeback() callback

[05/14] mm: add struct address_space to writepage() callback

Commit Message

Patch