From patchwork Sun Nov 8 14:03:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chengguang Xu X-Patchwork-Id: 11889571 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E670017EC for ; Sun, 8 Nov 2020 14:04:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CAEC4206F9 for ; Sun, 8 Nov 2020 14:04:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mykernel.net header.i=cgxu519@mykernel.net header.b="EVmBOh7k" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728540AbgKHOEN (ORCPT ); Sun, 8 Nov 2020 09:04:13 -0500 Received: from sender2-op-o12.zoho.com.cn ([163.53.93.243]:17154 "EHLO sender2-op-o12.zoho.com.cn" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728307AbgKHOEL (ORCPT ); Sun, 8 Nov 2020 09:04:11 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1604844204; cv=none; d=zoho.com.cn; s=zohoarc; b=AfIW3PvGM4TqXsUx9IqomkG4qfwSEVbO2Tiqo3xv5ZgP7tsPVD7+t5WQsFQ7DZuQkMZKj7baVuac50Ya5uTR+Tm6iFVcFL18wIwnSSp8M8920VWHYQPGtzAMDZUbFE+TZ0GqawIqpGTuMsEzyxam3741A28uTiMVdVq7TwRqTIo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com.cn; s=zohoarc; t=1604844204; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=XY1M6ngEHJazNPj3h/d5suhPsLhPCHaUvxhKABnNVTo=; b=D56m6oaZYLtgh9S78SCkK//0Zy81bes05Ed9dPlLmz1HGl/B81ycxmVIo+JedgPLi0nlyg7Sz7quLnSNLsgYWN6m/Twojt45QAvj3ZcZ/rflpsDB012thN+7ZhwoHVjp8XnhBIolyFOdafKQE2lambW6RT0M1OSb7ptBajSa25Q= ARC-Authentication-Results: i=1; mx.zoho.com.cn; dkim=pass header.i=mykernel.net; spf=pass smtp.mailfrom=cgxu519@mykernel.net; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1604844204; s=zohomail; d=mykernel.net; i=cgxu519@mykernel.net; h=From:To:Cc:Message-ID:Subject:Date:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Content-Type; bh=XY1M6ngEHJazNPj3h/d5suhPsLhPCHaUvxhKABnNVTo=; b=EVmBOh7kJ7TnDXi24rKjT0RnLSJs+h5oU3RBNdDMxAVeg9arsCkvOVjYHVtsn0s0 ka38P1Bq6ir2F/77RbNDZdGxc+SU45bDyoBN+U5P+FLOxz3iM3eiZvLU6jRBL2Hgrki Hppeq4p16TCxOa5oiW/WTtaIvYrnyYHkTYAuO3lU= Received: from localhost.localdomain (113.116.49.189 [113.116.49.189]) by mx.zoho.com.cn with SMTPS id 1604844203598419.0458980977053; Sun, 8 Nov 2020 22:03:23 +0800 (CST) From: Chengguang Xu To: miklos@szeredi.hu, jack@suse.cz, amir73il@gmail.com Cc: linux-unionfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, Chengguang Xu Message-ID: <20201108140307.1385745-4-cgxu519@mykernel.net> Subject: [RFC PATCH v3 03/10] ovl: implement ->writepages operation Date: Sun, 8 Nov 2020 22:03:00 +0800 X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201108140307.1385745-1-cgxu519@mykernel.net> References: <20201108140307.1385745-1-cgxu519@mykernel.net> MIME-Version: 1.0 X-ZohoCNMailClient: External Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Implement overlayfs' ->writepages operation so that we can sync dirty data/metadata to upper filesystem. If writeback mode is sync_mode we add overlayfs inode to extra syncfs wait list so that we can wait completion in ->syncfs. Signed-off-by: Chengguang Xu --- fs/overlayfs/inode.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/fs/overlayfs/inode.c b/fs/overlayfs/inode.c index b584dca845ba..1f5cbbc60b28 100644 --- a/fs/overlayfs/inode.c +++ b/fs/overlayfs/inode.c @@ -11,6 +11,7 @@ #include #include #include +#include #include "overlayfs.h" @@ -516,7 +517,30 @@ static const struct inode_operations ovl_special_inode_operations = { .update_time = ovl_update_time, }; +static int ovl_writepages(struct address_space *mapping, + struct writeback_control *wbc) +{ + struct inode *inode = mapping->host; + struct ovl_fs *ofs = inode->i_sb->s_fs_info; + struct inode *upper = ovl_inode_upper(inode); + int ret; + + if (!ovl_should_sync(ofs)) + return 0; + ret = sync_inode(upper, wbc); + if (!ret && wbc->for_sync == 1) { + spin_lock(&ofs->syncfs_wait_list_lock); + if (list_empty(&OVL_I(inode)->wait_list)) + list_add_tail(&OVL_I(inode)->wait_list, + &ofs->syncfs_wait_list); + spin_unlock(&ofs->syncfs_wait_list_lock); + } + + return ret; +} + static const struct address_space_operations ovl_aops = { + .writepages = ovl_writepages, /* For O_DIRECT dentry_open() checks f_mapping->a_ops->direct_IO */ .direct_IO = noop_direct_IO, };