Message ID | 20210112081905.1736581-1-hch@lst.de (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | iov_iter: fix the uaccess area in copy_compat_iovec_from_user | expand |
On Tue, Jan 12, 2021 at 09:19:05AM +0100, Christoph Hellwig wrote:
> sizeof needs to be called on the compat pointer, not the native one.
in #fixes and #for-next now...
diff --git a/lib/iov_iter.c b/lib/iov_iter.c index 1635111c5bd2af..a21e6a5792c5a5 100644 --- a/lib/iov_iter.c +++ b/lib/iov_iter.c @@ -1658,7 +1658,7 @@ static int copy_compat_iovec_from_user(struct iovec *iov, (const struct compat_iovec __user *)uvec; int ret = -EFAULT, i; - if (!user_access_begin(uvec, nr_segs * sizeof(*uvec))) + if (!user_access_begin(uiov, nr_segs * sizeof(*uiov))) return -EFAULT; for (i = 0; i < nr_segs; i++) {
sizeof needs to be called on the compat pointer, not the native one. Fixes: 89cd35c58bc2 ("iov_iter: transparently handle compat iovecs in import_iovec") Reported-by: David Laight <David.Laight@ACULAB.COM> Signed-off-by: Christoph Hellwig <hch@lst.de> --- lib/iov_iter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)