diff mbox series

[RFC,03/39] blkdev.h: add new trace ext as a queue member

Message ID 20210225070231.21136-4-chaitanya.kulkarni@wdc.com (mailing list archive)
State New
Headers show
Series blktrace: add block trace extension support | expand

Commit Message

Chaitanya Kulkarni Feb. 25, 2021, 7:01 a.m. UTC
Update a struct queue with block trace extension.

Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
 include/linux/blkdev.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Damien Le Moal Feb. 26, 2021, 4:35 a.m. UTC | #1
On 2021/02/25 16:03, Chaitanya Kulkarni wrote:
> Update a struct queue with block trace extension.
> 
> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
> ---
>  include/linux/blkdev.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> index c032cfe133c7..7c21f22f2077 100644
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -533,6 +533,7 @@ struct request_queue {
>  	struct mutex		debugfs_mutex;
>  #ifdef CONFIG_BLK_DEV_IO_TRACE
>  	struct blk_trace __rcu	*blk_trace;
> +	struct blk_trace_ext __rcu	*blk_trace_ext;
>  #endif
>  	/*
>  	 * for flush operations
> 

You lost me here... why is blk_trace_ext defined in addition to the existing
blk_trace ? Why not extend the definition of struct blk_trace ?

And this patch should probably be squashed into patch 2.
diff mbox series

Patch

diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index c032cfe133c7..7c21f22f2077 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -533,6 +533,7 @@  struct request_queue {
 	struct mutex		debugfs_mutex;
 #ifdef CONFIG_BLK_DEV_IO_TRACE
 	struct blk_trace __rcu	*blk_trace;
+	struct blk_trace_ext __rcu	*blk_trace_ext;
 #endif
 	/*
 	 * for flush operations