diff mbox series

[RFC,04/39] blktrace: add a new global list

Message ID 20210225070231.21136-5-chaitanya.kulkarni@wdc.com (mailing list archive)
State New
Headers show
Series blktrace: add block trace extension support | expand

Commit Message

Chaitanya Kulkarni Feb. 25, 2021, 7:01 a.m. UTC
Add a separate list to hold running extension traces.

Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
 kernel/trace/blktrace.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Damien Le Moal Feb. 26, 2021, 4:36 a.m. UTC | #1
On 2021/02/25 16:03, Chaitanya Kulkarni wrote:
> Add a separate list to hold running extension traces.
> 
> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
> ---
>  kernel/trace/blktrace.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
> index ca6f0ceba09b..e45bbfcb5daf 100644
> --- a/kernel/trace/blktrace.c
> +++ b/kernel/trace/blktrace.c
> @@ -36,6 +36,9 @@ static bool blk_tracer_enabled __read_mostly;
>  static LIST_HEAD(running_trace_list);
>  static __cacheline_aligned_in_smp DEFINE_SPINLOCK(running_trace_lock);
>  
> +static LIST_HEAD(running_trace_ext_list);
> +static __cacheline_aligned_in_smp DEFINE_SPINLOCK(running_trace_ext_lock);

Why is this necessary ? This is not explained. Why cannot you keep using
running_trace_lock ?

> +
>  /* Select an alternative, minimalistic output than the original one */
>  #define TRACE_BLK_OPT_CLASSIC	0x1
>  #define TRACE_BLK_OPT_CGROUP	0x2
>
diff mbox series

Patch

diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
index ca6f0ceba09b..e45bbfcb5daf 100644
--- a/kernel/trace/blktrace.c
+++ b/kernel/trace/blktrace.c
@@ -36,6 +36,9 @@  static bool blk_tracer_enabled __read_mostly;
 static LIST_HEAD(running_trace_list);
 static __cacheline_aligned_in_smp DEFINE_SPINLOCK(running_trace_lock);
 
+static LIST_HEAD(running_trace_ext_list);
+static __cacheline_aligned_in_smp DEFINE_SPINLOCK(running_trace_ext_lock);
+
 /* Select an alternative, minimalistic output than the original one */
 #define TRACE_BLK_OPT_CLASSIC	0x1
 #define TRACE_BLK_OPT_CGROUP	0x2