diff mbox series

uapi: fix comment about block device ioctl

Message ID 20210316011755.122306-1-damien.lemoal@wdc.com (mailing list archive)
State New, archived
Headers show
Series uapi: fix comment about block device ioctl | expand

Commit Message

Damien Le Moal March 16, 2021, 1:17 a.m. UTC
Fix the comment mentioning ioctl command range used for zoned block
devices to reflect the range of commands actually implemented.

Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
---
 include/uapi/linux/fs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Chaitanya Kulkarni March 16, 2021, 11:40 p.m. UTC | #1
On 3/15/21 18:18, Damien Le Moal wrote:
> Fix the comment mentioning ioctl command range used for zoned block
> devices to reflect the range of commands actually implemented.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>

I've verified that blkzoned.h contains the IOCTLs in the range of
130 - 136 in uapi/linux/blkzoned.h.

Looks good.

Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Damien Le Moal April 7, 2021, 12:39 p.m. UTC | #2
On 2021/03/16 10:18, Damien Le Moal wrote:
> Fix the comment mentioning ioctl command range used for zoned block
> devices to reflect the range of commands actually implemented.
> 
> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
> ---
>  include/uapi/linux/fs.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/uapi/linux/fs.h b/include/uapi/linux/fs.h
> index f44eb0a04afd..4c32e97dcdf0 100644
> --- a/include/uapi/linux/fs.h
> +++ b/include/uapi/linux/fs.h
> @@ -185,7 +185,7 @@ struct fsxattr {
>  #define BLKROTATIONAL _IO(0x12,126)
>  #define BLKZEROOUT _IO(0x12,127)
>  /*
> - * A jump here: 130-131 are reserved for zoned block devices
> + * A jump here: 130-136 are reserved for zoned block devices
>   * (see uapi/linux/blkzoned.h)
>   */

Al,

Ping ?
Can you take this or should it go through the blok tree ?
Jens Axboe April 8, 2021, 4:27 p.m. UTC | #3
On 3/15/21 7:17 PM, Damien Le Moal wrote:
> Fix the comment mentioning ioctl command range used for zoned block
> devices to reflect the range of commands actually implemented.

Reviewed-by: Jens Axboe <axboe@kernel.dk>
diff mbox series

Patch

diff --git a/include/uapi/linux/fs.h b/include/uapi/linux/fs.h
index f44eb0a04afd..4c32e97dcdf0 100644
--- a/include/uapi/linux/fs.h
+++ b/include/uapi/linux/fs.h
@@ -185,7 +185,7 @@  struct fsxattr {
 #define BLKROTATIONAL _IO(0x12,126)
 #define BLKZEROOUT _IO(0x12,127)
 /*
- * A jump here: 130-131 are reserved for zoned block devices
+ * A jump here: 130-136 are reserved for zoned block devices
  * (see uapi/linux/blkzoned.h)
  */