diff mbox series

[v2,12/14] ext4: Send notifications on error

Message ID 20210615235556.970928-13-krisman@collabora.com (mailing list archive)
State New
Headers show
Series File system wide monitoring | expand

Commit Message

Gabriel Krisman Bertazi June 15, 2021, 11:55 p.m. UTC
Send a FS_ERROR message via fsnotify to a userspace monitoring tool
whenever a ext4 error condition is triggered.  This follows the existing
error conditions in ext4, so it is hooked to the ext4_error* functions.

It also follows the current dmesg reporting in the format.  The
filesystem message is composed mostly by the string that would be
otherwise printed in dmesg.

A new ext4 specific record format is exposed in the uapi, such that a
monitoring tool knows what to expect when listening errors of an ext4

Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com>
Reviewed-by: Amir Goldstein <amir73il@gmail.com>
 fs/ext4/super.c | 8 ++++++++
 1 file changed, 8 insertions(+)
diff mbox series


diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index d29f6aa7d96e..b5a8c4bab3ab 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -46,6 +46,7 @@ 
 #include <linux/part_stat.h>
 #include <linux/kthread.h>
 #include <linux/freezer.h>
+#include <linux/fsnotify.h>
 #include "ext4.h"
 #include "ext4_extents.h"	/* Needed for trace points definition */
@@ -752,6 +753,8 @@  void __ext4_error(struct super_block *sb, const char *function,
 		       sb->s_id, function, line, current->comm, &vaf);
+	fsnotify_sb_error(sb, NULL, error);
 	ext4_handle_error(sb, force_ro, error, 0, block, function, line);
@@ -782,6 +785,8 @@  void __ext4_error_inode(struct inode *inode, const char *function,
 			       current->comm, &vaf);
+	fsnotify_sb_error(inode->i_sb, inode, error);
 	ext4_handle_error(inode->i_sb, false, error, inode->i_ino, block,
 			  function, line);
@@ -820,6 +825,8 @@  void __ext4_error_file(struct file *file, const char *function,
 			       current->comm, path, &vaf);
+	fsnotify_sb_error(inode->i_sb, inode, EFSCORRUPTED);
 	ext4_handle_error(inode->i_sb, false, EFSCORRUPTED, inode->i_ino, block,
 			  function, line);
@@ -887,6 +894,7 @@  void __ext4_std_error(struct super_block *sb, const char *function,
 		printk(KERN_CRIT "EXT4-fs error (device %s) in %s:%d: %s\n",
 		       sb->s_id, function, line, errstr);
+	fsnotify_sb_error(sb, sb->s_root->d_inode, errno);
 	ext4_handle_error(sb, false, -errno, 0, 0, function, line);