diff mbox series

[5/9] coda: Avoid hidden code duplication in rename.

Message ID 20210908140308.18491-6-jaharkes@cs.cmu.edu (mailing list archive)
State New, archived
Headers show
Series Coda updates for -next | expand

Commit Message

Jan Harkes Sept. 8, 2021, 2:03 p.m. UTC
We were actually fixing up the directory mtime in both branches after
the negative dentry test, it was just that one branch was only flagging
the directory inodes to refresh their attributes while the other branch
used the optional optimization to set mtime to the current time and not
go back to the Coda client.

Signed-off-by: Jan Harkes <jaharkes@cs.cmu.edu>
---
 fs/coda/dir.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
diff mbox series

Patch

diff --git a/fs/coda/dir.c b/fs/coda/dir.c
index 3fd085009f26..328d7a684b63 100644
--- a/fs/coda/dir.c
+++ b/fs/coda/dir.c
@@ -317,13 +317,10 @@  static int coda_rename(struct user_namespace *mnt_userns, struct inode *old_dir,
 				coda_dir_drop_nlink(old_dir);
 				coda_dir_inc_nlink(new_dir);
 			}
-			coda_dir_update_mtime(old_dir);
-			coda_dir_update_mtime(new_dir);
 			coda_flag_inode(d_inode(new_dentry), C_VATTR);
-		} else {
-			coda_flag_inode(old_dir, C_VATTR);
-			coda_flag_inode(new_dir, C_VATTR);
 		}
+		coda_dir_update_mtime(old_dir);
+		coda_dir_update_mtime(new_dir);
 	}
 	return error;
 }