diff mbox series

[6/7] proc/stat: Use unsigned int for "softirq" sum

Message ID 20210911034808.24252-7-me@ilammy.net (mailing list archive)
State Superseded, archived
Headers show
Series proc/stat: Maintain monotonicity of "intr" and "softirq" | expand

Commit Message

Alexei Lozovsky Sept. 11, 2021, 3:48 a.m. UTC 
Similarly to "intr" sum value, "softirq" sum is computed by adding up
unsigned int counters for each CPU returned by kstat_softirqs_cpu().
To preserve monotonicity, use the same integer type so that the sum
wraps around consistently. And just like before, this value does not
need to be explicitly casted into unsigned long long for display.

Signed-off-by: Alexei Lozovsky <me@ilammy.net>
---
 fs/proc/stat.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/fs/proc/stat.c b/fs/proc/stat.c
index d31b83b2a175..b7a7de3cd822 100644
--- a/fs/proc/stat.c
+++ b/fs/proc/stat.c
@@ -111,7 +111,7 @@  static int show_stat(struct seq_file *p, void *v)
 	u64 user, nice, system, idle, iowait, irq, softirq, steal;
 	u64 guest, guest_nice;
 	unsigned int sum = 0;
-	u64 sum_softirq = 0;
+	unsigned int sum_softirq = 0;
 	unsigned int per_softirq_sums[NR_SOFTIRQS] = {0};
 	struct timespec64 boottime;
 
@@ -208,7 +208,7 @@  static int show_stat(struct seq_file *p, void *v)
 		nr_running(),
 		nr_iowait());
 
-	seq_put_decimal_ull(p, "softirq ", (unsigned long long)sum_softirq);
+	seq_put_decimal_ull(p, "softirq ", sum_softirq);
 
 	for (i = 0; i < NR_SOFTIRQS; i++)
 		seq_put_decimal_ull(p, " ", per_softirq_sums[i]);